Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 291193009: Reland: Allow high-res bitmaps to be passed in from notifications API. (Closed)

Created:
6 years, 7 months ago by dewittj
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Reland: Allow high-res bitmaps to be passed in from notifications API. Previously the custom binding in JS would prevent an image that's larger than the size of the template from being sent to the browser process. This relaxes the maximum to be the largest supported scale factor of the machine. TBR=kalman@chromium.org,dimich@chromium.org BUG=239676 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274730

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Patch Set 3 : Rebase #

Patch Set 4 : Fix test post-rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+898 lines, -670 lines) Patch
M chrome/browser/extensions/api/notifications/notifications_api.cc View 1 2 13 chunks +63 lines, -18 lines 0 comments Download
M chrome/browser/extensions/api/notifications/notifications_apitest.cc View 1 2 3 chunks +15 lines, -615 lines 0 comments Download
M chrome/chrome_common.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/common/extensions/api/notifications/notification_style.h View 1 chunk +20 lines, -0 lines 0 comments Download
A chrome/common/extensions/api/notifications/notification_style.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
A chrome/renderer/extensions/notifications_native_handler.h View 1 chunk +42 lines, -0 lines 0 comments Download
A chrome/renderer/extensions/notifications_native_handler.cc View 1 chunk +48 lines, -0 lines 0 comments Download
M chrome/renderer/resources/extensions/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/renderer/resources/extensions/notifications_custom_bindings.gtestjs View 1 chunk +104 lines, -0 lines 0 comments Download
M chrome/renderer/resources/extensions/notifications_custom_bindings.js View 1 chunk +43 lines, -34 lines 0 comments Download
A chrome/renderer/resources/extensions/notifications_test_util.js View 1 chunk +53 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/notifications/api/basic_usage/background.js View 1 chunk +305 lines, -0 lines 0 comments Download
A + chrome/test/data/extensions/api_test/notifications/api/basic_usage/manifest.json View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/test/data/extensions/api_test/notifications/api/by_user/background.js View 2 chunks +25 lines, -4 lines 0 comments Download
A chrome/test/data/extensions/api_test/notifications/api/partial_update/background.js View 1 chunk +141 lines, -0 lines 0 comments Download
A + chrome/test/data/extensions/api_test/notifications/api/partial_update/manifest.json View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/test/data/extensions/api_test/notifications/api/user_gesture/background.js View 1 2 3 2 chunks +5 lines, -1 line 0 comments Download
M chrome/unit_tests.isolate View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
dewittj
csharp: Please take a look at isolate changes. kalman (TBR), dimich (TBR): no new code, ...
6 years, 7 months ago (2014-05-22 23:47:30 UTC) #1
dewittj
csharp: ping
6 years, 7 months ago (2014-05-23 22:49:53 UTC) #2
csharp
https://codereview.chromium.org/291193009/diff/20001/chrome/unit_tests.isolate File chrome/unit_tests.isolate (right): https://codereview.chromium.org/291193009/diff/20001/chrome/unit_tests.isolate#newcode105 chrome/unit_tests.isolate:105: '<(PRODUCT_DIR)/test_data/chrome/renderer/resources/extensions/', Do the tests not need access to these ...
6 years, 6 months ago (2014-05-26 13:05:54 UTC) #3
dewittj
https://codereview.chromium.org/291193009/diff/20001/chrome/unit_tests.isolate File chrome/unit_tests.isolate (right): https://codereview.chromium.org/291193009/diff/20001/chrome/unit_tests.isolate#newcode105 chrome/unit_tests.isolate:105: '<(PRODUCT_DIR)/test_data/chrome/renderer/resources/extensions/', On 2014/05/26 13:05:55, csharp wrote: > Do the ...
6 years, 6 months ago (2014-05-27 16:16:42 UTC) #4
csharp
lgtm https://codereview.chromium.org/291193009/diff/20001/chrome/unit_tests.isolate File chrome/unit_tests.isolate (right): https://codereview.chromium.org/291193009/diff/20001/chrome/unit_tests.isolate#newcode105 chrome/unit_tests.isolate:105: '<(PRODUCT_DIR)/test_data/chrome/renderer/resources/extensions/', On 2014/05/27 16:16:43, dewittj wrote: > On ...
6 years, 6 months ago (2014-05-27 16:56:34 UTC) #5
dewittj
technically the gjsunit tests run on all platforms. So I'll move it up.
6 years, 6 months ago (2014-06-02 17:33:02 UTC) #6
dewittj
The CQ bit was checked by dewittj@chromium.org
6 years, 6 months ago (2014-06-02 17:57:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dewittj@chromium.org/291193009/60001
6 years, 6 months ago (2014-06-02 17:58:39 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-06-02 21:19:44 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-02 21:23:40 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/71145)
6 years, 6 months ago (2014-06-02 21:23:40 UTC) #11
dewittj
The CQ bit was checked by dewittj@chromium.org
6 years, 6 months ago (2014-06-02 21:24:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dewittj@chromium.org/291193009/60001
6 years, 6 months ago (2014-06-02 21:25:17 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-03 01:51:47 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-03 02:52:58 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/33648)
6 years, 6 months ago (2014-06-03 02:52:59 UTC) #16
dewittj
The CQ bit was checked by dewittj@chromium.org
6 years, 6 months ago (2014-06-03 20:39:33 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dewittj@chromium.org/291193009/80001
6 years, 6 months ago (2014-06-03 20:40:24 UTC) #18
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 01:31:03 UTC) #19
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 08:40:49 UTC) #20
Message was sent while issue was closed.
Change committed as 274730

Powered by Google App Engine
This is Rietveld 408576698