Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 291193008: Handle odd width and height in the MediaSource renderer. (Closed)

Created:
6 years, 7 months ago by Sergey Ulanov
Modified:
6 years, 7 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Visibility:
Public.

Description

Handle odd width and height in the MediaSource renderer. Chrome requires video streams to have even width and height, so MediaSource renderer didn't work properly for streams with odd width or height. Fixed it to round up dimensions and crop one column or one row when screen size is odd, using Matroska's CropRight and CropBottom attributes. BUG=321825 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272430

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M remoting/client/plugin/media_source_video_renderer.cc View 1 chunk +17 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Sergey Ulanov
6 years, 7 months ago (2014-05-22 18:00:06 UTC) #1
Jamie
lgtm
6 years, 7 months ago (2014-05-22 18:19:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/291193008/1
6 years, 7 months ago (2014-05-22 18:22:02 UTC) #3
Sergey Ulanov
The CQ bit was unchecked by sergeyu@chromium.org
6 years, 7 months ago (2014-05-22 19:01:06 UTC) #4
Sergey Ulanov
Unchecked the commit bit. It won't compile until https://codereview.chromium.org/293053015/ lands (libwebm roll that adds support ...
6 years, 7 months ago (2014-05-22 19:02:04 UTC) #5
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 7 months ago (2014-05-22 19:36:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/291193008/1
6 years, 7 months ago (2014-05-22 19:38:32 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 07:26:45 UTC) #8
Message was sent while issue was closed.
Change committed as 272430

Powered by Google App Engine
This is Rietveld 408576698