Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1352)

Unified Diff: remoting/protocol/pseudotcp_adapter.cc

Issue 2911893003: Deprecate NonThreadSafe in remoting in favor of SequenceChecker. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/pseudotcp_adapter.h ('k') | remoting/protocol/session_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/pseudotcp_adapter.cc
diff --git a/remoting/protocol/pseudotcp_adapter.cc b/remoting/protocol/pseudotcp_adapter.cc
index 2ba797ee29de369c981cd562b881980be6aacb3d..2b89c7885d3620c06475a40f5166421dff127658 100644
--- a/remoting/protocol/pseudotcp_adapter.cc
+++ b/remoting/protocol/pseudotcp_adapter.cc
@@ -455,6 +455,7 @@ PseudoTcpAdapter::PseudoTcpAdapter(std::unique_ptr<P2PDatagramSocket> socket)
: core_(new Core(std::move(socket))) {}
PseudoTcpAdapter::~PseudoTcpAdapter() {
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
// Make sure that the underlying socket is destroyed before PseudoTcp.
core_->DeleteSocket();
}
@@ -462,46 +463,46 @@ PseudoTcpAdapter::~PseudoTcpAdapter() {
int PseudoTcpAdapter::Read(const scoped_refptr<net::IOBuffer>& buffer,
int buffer_size,
const net::CompletionCallback& callback) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
return core_->Read(buffer, buffer_size, callback);
}
int PseudoTcpAdapter::Write(const scoped_refptr<net::IOBuffer>& buffer,
int buffer_size,
const net::CompletionCallback& callback) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
return core_->Write(buffer, buffer_size, callback);
}
int PseudoTcpAdapter::SetReceiveBufferSize(int32_t size) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
core_->SetReceiveBufferSize(size);
return net::OK;
}
int PseudoTcpAdapter::SetSendBufferSize(int32_t size) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
core_->SetSendBufferSize(size);
return net::OK;
}
int PseudoTcpAdapter::Connect(const net::CompletionCallback& callback) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
return core_->Connect(callback);
}
void PseudoTcpAdapter::SetAckDelay(int delay_ms) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
core_->SetAckDelay(delay_ms);
}
void PseudoTcpAdapter::SetNoDelay(bool no_delay) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
core_->SetNoDelay(no_delay);
}
void PseudoTcpAdapter::SetWriteWaitsForSend(bool write_waits_for_send) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
core_->SetWriteWaitsForSend(write_waits_for_send);
}
« no previous file with comments | « remoting/protocol/pseudotcp_adapter.h ('k') | remoting/protocol/session_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698