Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Unified Diff: remoting/protocol/message_reader.cc

Issue 2911893003: Deprecate NonThreadSafe in remoting in favor of SequenceChecker. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/message_reader.h ('k') | remoting/protocol/pseudotcp_adapter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/message_reader.cc
diff --git a/remoting/protocol/message_reader.cc b/remoting/protocol/message_reader.cc
index 948ac2f6145f96a7e9b94d0ffe63aead70fe18c6..db9030bb963a09af9c26ad4a301978a4c537e76a 100644
--- a/remoting/protocol/message_reader.cc
+++ b/remoting/protocol/message_reader.cc
@@ -25,13 +25,15 @@ namespace protocol {
static const int kReadBufferSize = 4096;
MessageReader::MessageReader() : weak_factory_(this) {}
-MessageReader::~MessageReader() {}
+MessageReader::~MessageReader() {
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
+}
void MessageReader::StartReading(
P2PStreamSocket* socket,
const MessageReceivedCallback& message_received_callback,
const ReadFailedCallback& read_failed_callback) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
DCHECK(!socket_);
DCHECK(socket);
DCHECK(!message_received_callback.is_null());
@@ -44,7 +46,7 @@ void MessageReader::StartReading(
}
void MessageReader::DoRead() {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
// Don't try to read again if there is another read pending or we
// have messages that we haven't finished processing yet.
bool read_succeeded = true;
@@ -60,7 +62,7 @@ void MessageReader::DoRead() {
}
void MessageReader::OnRead(int result) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
DCHECK(read_pending_);
read_pending_ = false;
@@ -73,7 +75,7 @@ void MessageReader::OnRead(int result) {
}
void MessageReader::HandleReadResult(int result, bool* read_succeeded) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
if (closed_)
return;
@@ -95,7 +97,7 @@ void MessageReader::HandleReadResult(int result, bool* read_succeeded) {
}
void MessageReader::OnDataReceived(net::IOBuffer* data, int data_size) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
message_decoder_.AddData(data, data_size);
// Get list of all new messages first, and then call the callback
« no previous file with comments | « remoting/protocol/message_reader.h ('k') | remoting/protocol/pseudotcp_adapter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698