Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: third_party/WebKit/Source/core/editing/markers/CompositionMarker.h

Issue 2911733002: [DMC #25] Make DocumentMarker::GetType() virtual (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/markers/CompositionMarker.h
diff --git a/third_party/WebKit/Source/core/editing/markers/CompositionMarker.h b/third_party/WebKit/Source/core/editing/markers/CompositionMarker.h
index 719b9e049d380af051c8bef72fe108d4de9f9a48..9fe170cf81bcf598fbfc57b652ce6fbceb0a8027 100644
--- a/third_party/WebKit/Source/core/editing/markers/CompositionMarker.h
+++ b/third_party/WebKit/Source/core/editing/markers/CompositionMarker.h
@@ -22,6 +22,10 @@ class CORE_EXPORT CompositionMarker final : public DocumentMarker {
bool thick,
Color background_color);
+ // DocumentMarker implementations
+ MarkerType GetType() const;
yosin_UTC9 2017/05/29 05:17:08 nit: s/;/final ;/
+
+ // CompositionMarker-specific
Color UnderlineColor() const;
bool Thick() const;
Color BackgroundColor() const;

Powered by Google App Engine
This is Rietveld 408576698