Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 291173010: Mojo: Mojom: Remove support for octal. (Closed)

Created:
6 years, 7 months ago by viettrungluu
Modified:
6 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Mojo: Mojom: Remove support for octal. Don't allow octal in default (and constant) values. (Or any other values that may pop up.) R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272311

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -53 lines) Patch
M mojo/apps/js/bindings/sample_service_unittests.js View 1 chunk +9 lines, -12 lines 0 comments Download
M mojo/public/cpp/bindings/tests/sample_service_unittest.cc View 1 chunk +10 lines, -13 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/sample_service.mojom View 1 chunk +11 lines, -14 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/parse/lexer.py View 3 chunks +6 lines, -11 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/parse/parser.py View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/pylib/mojom_tests/parse/lexer_unittest.py View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom_tests/parse/parser_unittest.py View 1 chunk +69 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
viettrungluu
6 years, 7 months ago (2014-05-22 17:47:37 UTC) #1
sky
LGTM
6 years, 7 months ago (2014-05-22 19:31:04 UTC) #2
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 7 months ago (2014-05-22 19:31:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/291173010/1
6 years, 7 months ago (2014-05-22 19:33:45 UTC) #4
viettrungluu
6 years, 7 months ago (2014-05-22 20:44:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r272311 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698