Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 291173007: Pepper: Remove jsoncpp from trusted plugin. (Closed)

Created:
6 years, 7 months ago by teravest
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Pepper: Remove jsoncpp from trusted plugin. Now that manifest parsing has been moved to components/nacl, the trusted plugin no longer depends on jsoncpp. BUG=239656 R=dmichael@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272174

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M ppapi/native_client/src/trusted/plugin/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/native_client/src/trusted/plugin/pnacl_resources.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
teravest
6 years, 7 months ago (2014-05-21 19:22:33 UTC) #1
dmichael (off chromium)
lgtm!!
6 years, 7 months ago (2014-05-21 19:55:52 UTC) #2
teravest
The CQ bit was checked by teravest@chromium.org
6 years, 7 months ago (2014-05-21 21:25:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/291173007/20001
6 years, 7 months ago (2014-05-21 21:29:38 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 13:59:48 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 14:01:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/9775)
6 years, 7 months ago (2014-05-22 14:01:50 UTC) #7
teravest
6 years, 7 months ago (2014-05-22 14:04:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r272174 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698