Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 291173006: Revert 271764 "Detaching from the VM after calling MediaStreamMa..." (Closed)

Created:
6 years, 7 months ago by Nicolas Zea
Modified:
6 years, 7 months ago
Reviewers:
jiayl
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 271764 "Detaching from the VM after calling MediaStreamMa..." Breaks androidwebview_instrumentation_tests org.chromium.android_webview.test.MediaAccessPermissionRequestTest#testGrantAccess http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20Tests%20%28dbg%29&number=20509 > Detaching from the VM after calling MediaStreamManager::SendMessageToNativeLog on Android. > MediaStreamManager::SendMessageToNativeLog posts a task to the UI thread, which will attach the audio thread to the Android java VM. Unlike chrome created threads, the audio thread is owned by the OS and does not detach itself from the VM on exit, causing a crash. > Since the log message is still crucial for diagnosing audio input issues, I'm detaching the VM after SendMessageToNativeLog, instead of removing the call on Android. > > BUG=365915 > > Review URL: https://codereview.chromium.org/294803003 TBR=jiayl@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271788

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -14 lines) Patch
M trunk/src/content/browser/renderer_host/media/audio_input_sync_writer.cc View 2 chunks +1 line, -14 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nicolas Zea
6 years, 7 months ago (2014-05-21 00:33:34 UTC) #1
Nicolas Zea
6 years, 7 months ago (2014-05-21 00:33:41 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r271788 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698