|
|
Created:
6 years, 7 months ago by sheyang Modified:
6 years, 6 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
DescriptionReplace unused CANONICAL_URL with PROJECT
NOTRY=true
TBR=darin@chromium.org
BUG=374398
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274920
Patch Set 1 #
Messages
Total messages: 21 (0 generated)
lgtm
Hi Darin, Would you LGTM this CL? Best regards, Sheng On Tue, May 20, 2014 at 4:09 PM, <iannucci@chromium.org> wrote: > lgtm > > > > https://codereview.chromium.org/291173005/ > To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Ping... Best regards, Sheng On Fri, May 23, 2014 at 9:11 AM, Sheng Yang <sheyang@google.com> wrote: > Hi Darin, > > Would you LGTM this CL? > > Best regards, > > Sheng > > > On Tue, May 20, 2014 at 4:09 PM, <iannucci@chromium.org> wrote: > >> lgtm >> >> >> >> https://codereview.chromium.org/291173005/ >> > > To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
darin: one line config change, PTAL :)
Hi Darin, Would you please take a loot when you have time? Best regards, Sheng On Thu, May 29, 2014 at 7:17 PM, <iannucci@chromium.org> wrote: > darin: one line config change, PTAL :) > > https://codereview.chromium.org/291173005/ > To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
I would just TBR it at this point
The CQ bit was checked by sheyang@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sheyang@chromium.org/291173005/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...) linux_chromium_gn_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
The CQ bit was checked by sheyang@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sheyang@chromium.org/291173005/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
The CQ bit was checked by sheyang@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sheyang@chromium.org/291173005/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
Message was sent while issue was closed.
Change committed as 274920 |