Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 291173005: Replace unused CANONICAL_URL with Project (Closed)

Created:
6 years, 7 months ago by sheyang
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Replace unused CANONICAL_URL with PROJECT NOTRY=true TBR=darin@chromium.org BUG=374398 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274920

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M codereview.settings View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (0 generated)
sheyang
6 years, 7 months ago (2014-05-20 23:08:03 UTC) #1
iannucci
lgtm
6 years, 7 months ago (2014-05-20 23:09:55 UTC) #2
chromium-reviews
Hi Darin, Would you LGTM this CL? Best regards, Sheng On Tue, May 20, 2014 ...
6 years, 7 months ago (2014-05-23 16:11:47 UTC) #3
chromium-reviews
Ping... Best regards, Sheng On Fri, May 23, 2014 at 9:11 AM, Sheng Yang <sheyang@google.com> ...
6 years, 6 months ago (2014-05-27 17:12:12 UTC) #4
iannucci
darin: one line config change, PTAL :)
6 years, 6 months ago (2014-05-30 02:17:38 UTC) #5
chromium-reviews
Hi Darin, Would you please take a loot when you have time? Best regards, Sheng ...
6 years, 6 months ago (2014-06-04 02:00:04 UTC) #6
iannucci
I would just TBR it at this point
6 years, 6 months ago (2014-06-04 02:04:59 UTC) #7
sheyang
The CQ bit was checked by sheyang@chromium.org
6 years, 6 months ago (2014-06-04 15:54:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sheyang@chromium.org/291173005/1
6 years, 6 months ago (2014-06-04 15:56:07 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 19:23:34 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 19:37:36 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/10464)
6 years, 6 months ago (2014-06-04 19:37:36 UTC) #12
sheyang
The CQ bit was checked by sheyang@chromium.org
6 years, 6 months ago (2014-06-04 19:38:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sheyang@chromium.org/291173005/1
6 years, 6 months ago (2014-06-04 19:41:58 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 19:48:18 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 19:53:58 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/10477)
6 years, 6 months ago (2014-06-04 19:53:59 UTC) #17
sheyang
The CQ bit was checked by sheyang@chromium.org
6 years, 6 months ago (2014-06-04 21:06:55 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sheyang@chromium.org/291173005/1
6 years, 6 months ago (2014-06-04 21:10:51 UTC) #19
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 21:28:18 UTC) #20
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 21:54:26 UTC) #21
Message was sent while issue was closed.
Change committed as 274920

Powered by Google App Engine
This is Rietveld 408576698