Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Unified Diff: net/http/http_stream_factory_impl_job.cc

Issue 291173003: Trivial cleanup of HttpStreamFactoryImpl::Job::DoInitConnection (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_stream_factory_impl_job.cc
diff --git a/net/http/http_stream_factory_impl_job.cc b/net/http/http_stream_factory_impl_job.cc
index 5f12baaf8cdf2ecbbf755cf950322c073e833338..b360beee4418a65b5050f36f2840834f90255a72 100644
--- a/net/http/http_stream_factory_impl_job.cc
+++ b/net/http/http_stream_factory_impl_job.cc
@@ -848,31 +848,32 @@ int HttpStreamFactoryImpl::Job::DoInitConnection() {
request_info_.privacy_mode,
net_log_,
num_streams_);
- } else {
- // If we can't use a SPDY session, don't both checking for one after
- // the hostname is resolved.
- OnHostResolutionCallback resolution_callback = CanUseExistingSpdySession() ?
- base::Bind(&Job::OnHostResolution, session_->spdy_session_pool(),
- GetSpdySessionKey()) :
- OnHostResolutionCallback();
- if (stream_factory_->for_websockets_) {
- // TODO(ricea): Re-enable NPN when WebSockets over SPDY is supported.
- SSLConfig websocket_server_ssl_config = server_ssl_config_;
- websocket_server_ssl_config.next_protos.clear();
- return InitSocketHandleForWebSocketRequest(
- origin_url_, request_info_.extra_headers, request_info_.load_flags,
- priority_, session_, proxy_info_, ShouldForceSpdySSL(),
- want_spdy_over_npn, websocket_server_ssl_config, proxy_ssl_config_,
- request_info_.privacy_mode, net_log_,
- connection_.get(), resolution_callback, io_callback_);
- }
- return InitSocketHandleForHttpRequest(
+ }
+
+ // If we can't use a SPDY session, don't both checking for one after
+ // the hostname is resolved.
+ OnHostResolutionCallback resolution_callback = CanUseExistingSpdySession() ?
+ base::Bind(&Job::OnHostResolution, session_->spdy_session_pool(),
+ GetSpdySessionKey()) :
+ OnHostResolutionCallback();
+ if (stream_factory_->for_websockets_) {
+ // TODO(ricea): Re-enable NPN when WebSockets over SPDY is supported.
+ SSLConfig websocket_server_ssl_config = server_ssl_config_;
+ websocket_server_ssl_config.next_protos.clear();
+ return InitSocketHandleForWebSocketRequest(
origin_url_, request_info_.extra_headers, request_info_.load_flags,
priority_, session_, proxy_info_, ShouldForceSpdySSL(),
- want_spdy_over_npn, server_ssl_config_, proxy_ssl_config_,
+ want_spdy_over_npn, websocket_server_ssl_config, proxy_ssl_config_,
request_info_.privacy_mode, net_log_,
connection_.get(), resolution_callback, io_callback_);
}
+
+ return InitSocketHandleForHttpRequest(
+ origin_url_, request_info_.extra_headers, request_info_.load_flags,
+ priority_, session_, proxy_info_, ShouldForceSpdySSL(),
+ want_spdy_over_npn, server_ssl_config_, proxy_ssl_config_,
+ request_info_.privacy_mode, net_log_,
+ connection_.get(), resolution_callback, io_callback_);
}
int HttpStreamFactoryImpl::Job::DoInitConnectionComplete(int result) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698