third_party/WebKit/Source/web/ContextMenuClientImpl.cpp - Issue 2911723002: [DMC #24] Add SpellingMarker and GrammarMarker (subclasses of DocumentMarker)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ContextMenuClientImpl.cpp

Issue 2911723002: [DMC #24] Add SpellingMarker and GrammarMarker (subclasses of DocumentMarker) (Closed)

Patch Set: Add IsSpellCheckMarker() tests Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/ContextMenuClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp b/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp

index 9328735443e33cc927825e6f59d358f3038b0fa8..1bda24f72f22bd3cf840c1abcd1eba5b2f303b8a 100644

--- a/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp

+++ b/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp

@@ -39,6 +39,7 @@

#include "core/dom/ElementTraversal.h"

#include "core/editing/Editor.h"

#include "core/editing/markers/DocumentMarkerController.h"

+#include "core/editing/markers/SpellCheckMarker.h"

#include "core/editing/spellcheck/SpellChecker.h"

#include "core/exported/WebDataSourceImpl.h"

#include "core/exported/WebPluginContainerBase.h"

@@ -144,7 +145,7 @@ static String SelectMisspellingAsync(LocalFrame* selected_frame,

if (marker_it == markers_in_node.end())

return String();

- const DocumentMarker* const found_marker = *marker_it;

+ const SpellCheckMarker* const found_marker = ToSpellCheckMarker(*marker_it);

description = found_marker->Description();

Range* const marker_range =

« no previous file with comments | « third_party/WebKit/Source/core/testing/Internals.cpp ('k') | no next file » | no next file with comments »