Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: third_party/WebKit/Source/core/editing/markers/SpellCheckMarker.h

Issue 2911723002: [DMC #24] Add SpellingMarker and GrammarMarker (subclasses of DocumentMarker) (Closed)
Patch Set: Rebase, respond to comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef SpellCheckMarker_h
6 #define SpellCheckMarker_h
7
8 #include "core/editing/markers/DocumentMarker.h"
9
10 namespace blink {
11
12 class CORE_EXPORT SpellCheckMarker : public DocumentMarker {
yosin_UTC9 2017/06/01 03:29:12 Please add a class comment.
13 public:
14 SpellCheckMarker(DocumentMarker::MarkerType,
Xiaocheng 2017/05/31 22:17:16 The ctor should be protected.
15 unsigned start_offset,
16 unsigned end_offset,
17 const String& description);
18
19 const String& Description() const;
yosin_UTC9 2017/06/01 03:29:12 nit: Since this simple getter, you can implement h
20
21 private:
22 const String description_;
23 };
yosin_UTC9 2017/06/01 03:29:12 nit: Could you add DISALLOW_COPY_AND_ASSING()?
24
25 DEFINE_TYPE_CASTS(SpellCheckMarker,
26 DocumentMarker,
27 marker,
28 marker->GetType() == DocumentMarker::kSpelling ||
29 marker->GetType() == DocumentMarker::kGrammar,
30 marker.GetType() == DocumentMarker::kSpelling ||
31 marker.GetType() == DocumentMarker::kGrammar);
32
33 } // namespace blink
34
35 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698