Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2911683003: Add type inference support for "call" invocations of function expressions. (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add type inference support for "call" invocations of function expressions. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/5d69e056d354c4e1e99470a0c382e587c0eeb31b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -13 lines) Patch
M pkg/analyzer/test/src/task/strong/front_end_inference_test.dart View 1 chunk +15 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart View 1 chunk +7 lines, -3 lines 0 comments Download
M pkg/front_end/test/fasta/strong.status View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_basic_downward_inference.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_basic_downward_inference.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_downwards_inference_fold.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A pkg/front_end/testcases/inference/unsafe_block_closure_inference_closure_call.dart.strong.expect View 1 chunk +9 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_explicit_dynamic_param_via_expr2.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_explicit_type_param_via_expr2.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_implicit_type_param_via_expr.dart View 1 chunk +1 line, -1 line 0 comments Download
A pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_implicit_type_param_via_expr.dart.strong.expect View 1 chunk +11 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_no_type_param_via_expr.dart.strong.expect View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 7 months ago (2017-05-26 20:25:13 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-26 20:30:53 UTC) #3
Paul Berry
3 years, 7 months ago (2017-05-26 20:34:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5d69e056d354c4e1e99470a0c382e587c0eeb31b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698