Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 291163006: Create GPUMetricsProvider. (Closed)

Created:
6 years, 7 months ago by blundell
Modified:
6 years, 7 months ago
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org
Visibility:
Public.

Description

Create GPUMetricsProvider. This CL moves the GPU-related system profile metrics logging out of MetricsLog into GPUMetricsProvider, which is a metrics::MetricsProvider. A new unittest is created to provide the related test coverage that was previously provided in the MetricsLog unittest. BUG=374228 R=asvitkine@chromium.org, isherman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272484

Patch Set 1 #

Patch Set 2 : Move the Windows-specific call #

Total comments: 8

Patch Set 3 : Response to review #

Total comments: 2

Patch Set 4 : Response to review #

Total comments: 4

Patch Set 5 : Response to review #

Patch Set 6 : Rebase #

Patch Set 7 : Windows fix #

Patch Set 8 : Rebase #

Patch Set 9 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -124 lines) Patch
A chrome/browser/metrics/gpu_metrics_provider.h View 1 2 3 4 5 1 chunk +38 lines, -0 lines 0 comments Download
A chrome/browser/metrics/gpu_metrics_provider.cc View 1 2 3 4 5 6 1 chunk +108 lines, -0 lines 0 comments Download
A chrome/browser/metrics/gpu_metrics_provider_unittest.cc View 1 2 3 4 5 1 chunk +64 lines, -0 lines 0 comments Download
M chrome/browser/metrics/metrics_log.h View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/metrics/metrics_log.cc View 1 2 3 4 5 6 7 8 5 chunks +0 lines, -81 lines 0 comments Download
M chrome/browser/metrics/metrics_log_unittest.cc View 1 2 3 4 5 6 7 8 4 chunks +0 lines, -21 lines 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/metrics/metrics_service_unittest.cc View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -13 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 25 (0 generated)
blundell
6 years, 7 months ago (2014-05-20 14:07:29 UTC) #1
Alexei Svitkine (slow)
https://codereview.chromium.org/291163006/diff/40001/chrome/browser/metrics/gpu_metrics_provider.h File chrome/browser/metrics/gpu_metrics_provider.h (right): https://codereview.chromium.org/291163006/diff/40001/chrome/browser/metrics/gpu_metrics_provider.h#newcode34 chrome/browser/metrics/gpu_metrics_provider.h:34: DISALLOW_COPY_AND_ASSIGN(GPUMetricsProvider); This should be in the private section. https://codereview.chromium.org/291163006/diff/40001/chrome/browser/metrics/gpu_metrics_provider_unittest.cc ...
6 years, 7 months ago (2014-05-20 14:16:36 UTC) #2
blundell
https://codereview.chromium.org/291163006/diff/40001/chrome/browser/metrics/gpu_metrics_provider.h File chrome/browser/metrics/gpu_metrics_provider.h (right): https://codereview.chromium.org/291163006/diff/40001/chrome/browser/metrics/gpu_metrics_provider.h#newcode34 chrome/browser/metrics/gpu_metrics_provider.h:34: DISALLOW_COPY_AND_ASSIGN(GPUMetricsProvider); On 2014/05/20 14:16:37, Alexei Svitkine wrote: > This ...
6 years, 7 months ago (2014-05-20 14:20:49 UTC) #3
Alexei Svitkine (slow)
LGTM, thanks! https://codereview.chromium.org/291163006/diff/60001/chrome/browser/metrics/gpu_metrics_provider.cc File chrome/browser/metrics/gpu_metrics_provider.cc (right): https://codereview.chromium.org/291163006/diff/60001/chrome/browser/metrics/gpu_metrics_provider.cc#newcode98 chrome/browser/metrics/gpu_metrics_provider.cc:98: .device_scale_factor(); FWIW, I like the previous wrapping ...
6 years, 7 months ago (2014-05-20 14:23:29 UTC) #4
blundell
https://codereview.chromium.org/291163006/diff/60001/chrome/browser/metrics/gpu_metrics_provider.cc File chrome/browser/metrics/gpu_metrics_provider.cc (right): https://codereview.chromium.org/291163006/diff/60001/chrome/browser/metrics/gpu_metrics_provider.cc#newcode98 chrome/browser/metrics/gpu_metrics_provider.cc:98: .device_scale_factor(); Agreed. Changed. On 2014/05/20 14:23:30, Alexei Svitkine wrote: ...
6 years, 7 months ago (2014-05-20 14:32:53 UTC) #5
Ilya Sherman
LGTM with nits. https://codereview.chromium.org/291163006/diff/80001/chrome/browser/metrics/gpu_metrics_provider.cc File chrome/browser/metrics/gpu_metrics_provider.cc (right): https://codereview.chromium.org/291163006/diff/80001/chrome/browser/metrics/gpu_metrics_provider.cc#newcode49 chrome/browser/metrics/gpu_metrics_provider.cc:49: } nit: Should this all be ...
6 years, 7 months ago (2014-05-20 14:40:26 UTC) #6
blundell
https://codereview.chromium.org/291163006/diff/80001/chrome/browser/metrics/gpu_metrics_provider.cc File chrome/browser/metrics/gpu_metrics_provider.cc (right): https://codereview.chromium.org/291163006/diff/80001/chrome/browser/metrics/gpu_metrics_provider.cc#newcode49 chrome/browser/metrics/gpu_metrics_provider.cc:49: } On 2014/05/20 14:40:27, Ilya Sherman wrote: > nit: ...
6 years, 7 months ago (2014-05-20 14:59:10 UTC) #7
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 7 months ago (2014-05-20 19:35:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/291163006/120001
6 years, 7 months ago (2014-05-20 19:35:18 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 23:30:40 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-21 00:45:35 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/29206)
6 years, 7 months ago (2014-05-21 00:45:35 UTC) #12
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 7 months ago (2014-05-21 09:15:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/291163006/140001
6 years, 7 months ago (2014-05-21 09:17:43 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-21 20:02:20 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-21 20:10:58 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/7652)
6 years, 7 months ago (2014-05-21 20:10:59 UTC) #17
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 7 months ago (2014-05-22 14:00:29 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/291163006/160001
6 years, 7 months ago (2014-05-22 14:02:08 UTC) #19
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 18:04:35 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 18:10:21 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/6736) chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/69274) linux_chromium_chromeos_rel ...
6 years, 7 months ago (2014-05-22 18:10:22 UTC) #22
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 7 months ago (2014-05-23 08:49:02 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/291163006/180001
6 years, 7 months ago (2014-05-23 08:49:30 UTC) #24
blundell
6 years, 7 months ago (2014-05-23 11:02:31 UTC) #25
Message was sent while issue was closed. 
Committed patchset #9 manually as r272484 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698