Revert ""Revert of eliminate config param -- it was always self's config (https://codereview.chromi…

Revert ""Revert of eliminate config param -- it was always self's config (https://codereview.chromium.org/246513002/)"""

This reverts commit 3dbceb4f8283b2fb1728d0daf010d036099a2eae.

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=14806

[reed1, 2014-05-20 12:42:51]

last time this broke a webgl conformance test, asserting on SkBitmap.cpp:318

            SkASSERT(info.fColorType == prInfo.fColorType);

Somehow setPixelRef was called when the bitmap and the pixelref had different
colortypes (but I don't know who the caller was)

[reed1, 2014-05-20 12:43:35]

This is triggering asserts in the webgl conformance tests:
http://build.chromium.org/p/chromium.gpu/builders/Mac%20Retina%20Debug/builds...

[2240:1287:0519/143606:INFO:SkBitmap.cpp(318)]
../../third_party/skia/src/core/SkBitmap.cpp:318: failed assertion
"info.fColorType == prInfo.fColorType"

[2240:1287:0519/143606:FATAL:SkBitmap.cpp(318)] SK_CRASH
0   libbase.dylib                       0x0b96c0af
base::debug::StackTrace::StackTrace() + 63
1   libbase.dylib                       0x0b96c10b
base::debug::StackTrace::StackTrace() + 43
2   libbase.dylib                       0x0ba13c92
logging::LogMessage::~LogMessage() + 82
3   libbase.dylib                       0x0ba1270b
logging::LogMessage::~LogMessage() + 43
4   libskia.dylib                       0x22fddc1e SkDebugf_FileLine(char
const*, int, bool, char const*, ...) + 286
5   libskia.dylib                       0x22c6a491
SkBitmap::setPixelRef(SkPixelRef*, int, int) + 609
6   libskia.dylib                       0x22c723c2
SkBitmap::setPixelRef(SkPixelRef*) + 82
7   libskia.dylib                       0x22c6e081
SkBitmap::extractSubset(SkBitmap*, SkIRect const&) const + 561
8   libskia.dylib                       0x22c75f3d
SkBitmapDevice::drawBitmapRect(SkDraw const&, SkBitmap const&, SkRect const*,
SkRect const&, SkPaint const&, SkCanvas::DrawBitmapRectFlags) + 557
9   libskia.dylib                       0x22cdc9f8
SkCanvas::internalDrawBitmapRect(SkBitmap const&, SkRect const*, SkRect const&,
SkPaint const*, SkCanvas::DrawBitmapRectFlags) + 792
10  libskia.dylib                       0x22cdcad9
SkCanvas::drawBitmapRectToRect(SkBitmap const&, SkRect const*, SkRect const&,
SkPaint const*, SkCanvas::DrawBitmapRectFlags) + 137
11  libblink_platform.dylib             0x21c69a08
WebCore::GraphicsContext::drawBitmapRect(SkBitmap const&, SkRect const*, SkRect
const&, SkPaint const*) + 184
12  libblink_platform.dylib             0x21c31e84
WebCore::NativeImageSkia::draw(WebCore::GraphicsContext*, SkRect const&, SkRect
const&, WTF::PassRefPtr<SkXfermode>) const + 1476
13  libblink_platform.dylib             0x21c3d121
WebCore::BitmapImage::draw(WebCore::GraphicsContext*, WebCore::FloatRect const&,
WebCore::FloatRect const&, WebCore::CompositeOperator, blink::WebBlendMode,
WebCore::RespectImageOrientationEnum) + 1425
14  libblink_platform.dylib             0x21c68f91
WebCore::GraphicsContext::drawImage(WebCore::Image*, WebCore::FloatRect const&,
WebCore::FloatRect const&, WebCore::CompositeOperator, blink::WebBlendMode,
WebCore::RespectImageOrientationEnum) + 193
15  libblink_web.dylib                  0x13b0511a
WebCore::CanvasRenderingContext2D::drawImageInternal(WebCore::CanvasImageSource*,
float, float, float, float, float, float, float, float,
WebCore::ExceptionState&, WebCore::CompositeOperator, blink::WebBlendMode) +
2058
16  libblink_web.dylib                  0x13b048e7
WebCore::CanvasRenderingContext2D::drawImage(WebCore::CanvasImageSource*, float,
float, float, float, float, float, float, float, WebCore::ExceptionState&) + 375
17  libblink_web.dylib                  0x13b0474d
WebCore::CanvasRenderingContext2D::drawImage(WebCore::CanvasImageSource*, float,
float, float, float, WebCore::ExceptionState&) + 269
18  libblink_web.dylib                  0x130029e9
WebCore::CanvasRenderingContext2DV8Internal::drawImage5Method(v8::FunctionCallbackInfo<v8::Value>
const&) + 4409
19  libblink_web.dylib                  0x12ffc619
WebCore::CanvasRenderingContext2DV8Internal::drawImageMethod(v8::FunctionCallbackInfo<v8::Value>
const&) + 3625
20  libblink_web.dylib                  0x12fdf60a
WebCore::CanvasRenderingContext2DV8Internal::drawImageMethodCallback(v8::FunctionCallbackInfo<v8::Value>
const&) + 58


To repro locally, build debug chrome and run

content/test/gpu/run_gpu_test.py webgl_conformance --show-stdout
--output-format=gtest --browser=debug -v

[reed1, 2014-05-20 15:27:32]

#3 should fix the bug. PTAL

[bsalomon, 2014-05-20 15:34:12]

lgtm

[reed1, 2014-05-20 17:03:25]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-05-20 17:03:43]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/reed@google.com/291163005/50001

[commit-bot: I haz the power, 2014-05-20 17:08:17]

Change committed as 14806

[reed1, 2014-05-21 15:57:10]

A revert of this CL has been created in
https://codereview.chromium.org/295093003/ by reed@google.com.

The reason for reverting is: broke 6 webgl/canvas tests in blink (don't know why
yet)

https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_7/2...
.