Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1215)

Unified Diff: components/metrics/metrics_service_client.h

Issue 291153013: Make MetricsService upload logs through an interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Casts for win64 compile Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/metrics/metrics_log_uploader.cc ('k') | components/metrics/net/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/metrics_service_client.h
===================================================================
--- components/metrics/metrics_service_client.h (revision 274045)
+++ components/metrics/metrics_service_client.h (working copy)
@@ -9,10 +9,13 @@
#include "base/basictypes.h"
#include "base/callback_forward.h"
+#include "base/memory/scoped_ptr.h"
#include "components/metrics/proto/system_profile.pb.h"
namespace metrics {
+class MetricsLogUploader;
+
// An abstraction of operations that depend on the embedder's (e.g. Chrome)
// environment.
class MetricsServiceClient {
@@ -50,6 +53,13 @@
// extra histograms that will go in that log. Asynchronous API - the client
// implementation should call |done_callback| when complete.
virtual void CollectFinalMetrics(const base::Closure& done_callback) = 0;
+
+ // Creates a MetricsLogUploader with the specified parameters (see comments on
+ // MetricsLogUploader for details).
+ virtual scoped_ptr<MetricsLogUploader> CreateUploader(
+ const std::string& server_url,
+ const std::string& mime_type,
+ const base::Callback<void(int)>& on_upload_complete) = 0;
};
} // namespace metrics
« no previous file with comments | « components/metrics/metrics_log_uploader.cc ('k') | components/metrics/net/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698