Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 291153013: Make MetricsService upload logs through an interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Casts for win64 compile Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/metrics/chrome_metrics_service_client.h ('k') | chrome/browser/metrics/compression_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/chrome_metrics_service_client.cc
===================================================================
--- chrome/browser/metrics/chrome_metrics_service_client.cc (revision 274045)
+++ chrome/browser/metrics/chrome_metrics_service_client.cc (working copy)
@@ -4,6 +4,8 @@
#include "chrome/browser/metrics/chrome_metrics_service_client.h"
+#include <vector>
+
#include "base/bind.h"
#include "base/callback.h"
#include "base/command_line.h"
@@ -26,6 +28,7 @@
#include "chrome/common/chrome_version_info.h"
#include "chrome/common/crash_keys.h"
#include "chrome/common/render_messages.h"
+#include "components/metrics/net/net_metrics_log_uploader.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/histogram_fetcher.h"
#include "content/public/browser/notification_service.h"
@@ -182,6 +185,17 @@
network_stats_uploader_.CollectAndReportNetworkStats();
}
+void ChromeMetricsServiceClient::StartGatheringMetrics(
+ const base::Closure& done_callback) {
+// TODO(blundell): Move all metrics gathering tasks from MetricsService to
+// here.
+#if defined(OS_CHROMEOS)
+ chromeos_metrics_provider_->InitTaskGetHardwareClass(done_callback);
+#else
+ done_callback.Run();
+#endif
+}
+
void ChromeMetricsServiceClient::CollectFinalMetrics(
const base::Closure& done_callback) {
DCHECK(thread_checker_.CalledOnValidThread());
@@ -212,6 +226,17 @@
}
}
+scoped_ptr<metrics::MetricsLogUploader>
+ChromeMetricsServiceClient::CreateUploader(
+ const std::string& server_url,
+ const std::string& mime_type,
+ const base::Callback<void(int)>& on_upload_complete) {
+ return scoped_ptr<metrics::MetricsLogUploader>(
+ new metrics::NetMetricsLogUploader(
+ g_browser_process->system_request_context(), server_url, mime_type,
+ on_upload_complete));
+}
+
void ChromeMetricsServiceClient::OnMemoryDetailCollectionDone() {
DCHECK(thread_checker_.CalledOnValidThread());
@@ -335,17 +360,6 @@
}
}
-void ChromeMetricsServiceClient::StartGatheringMetrics(
- const base::Closure& done_callback) {
-// TODO(blundell): Move all metrics gathering tasks from MetricsService to
-// here.
-#if defined(OS_CHROMEOS)
- chromeos_metrics_provider_->InitTaskGetHardwareClass(done_callback);
-#else
- done_callback.Run();
-#endif
-}
-
#if defined(OS_WIN)
void ChromeMetricsServiceClient::CountBrowserCrashDumpAttempts() {
// Open the registry key for iteration.
« no previous file with comments | « chrome/browser/metrics/chrome_metrics_service_client.h ('k') | chrome/browser/metrics/compression_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698