Issue 291153012: Consolidated enhanced bookmarks experiment logic in one place.

Issue 291153012: Consolidated enhanced bookmarks experiment logic in one place. (Closed)

Created:
6 years, 7 months ago by yefimt

Modified:
6 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, tfarina, haitaol+watch_chromium.org, browser-components-watch_chromium.org, chromium-apps-reviews_chromium.org, maniscalco+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Consolidated enhanced bookmarks experiment logic in one place. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272730

Patch Set 1 #

Total comments: 2

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -52 lines)			Patch
M	chrome/browser/bookmarks/enhanced_bookmarks_features.h	View	2 chunks	+6 lines, -3 lines	1 comment	Download
M	chrome/browser/bookmarks/enhanced_bookmarks_features.cc	View	4 chunks	+20 lines, -15 lines	1 comment	Download
M	chrome/browser/extensions/external_component_loader.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/sync/profile_sync_service.cc	View	1 chunk	+7 lines, -33 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/291153012/diff/1/chrome/browser/bookmarks/enhanced_bookmarks_features.cc File chrome/browser/bookmarks/enhanced_bookmarks_features.cc (right): https://codereview.chromium.org/291153012/diff/1/chrome/browser/bookmarks/enhanced_bookmarks_features.cc#newcode94 chrome/browser/bookmarks/enhanced_bookmarks_features.cc:94: } else if (experiment_enabled_from_sync == kBookmarksExperimentEnabled) { How ...

6 years, 7 months ago (2014-05-23 19:51:55 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yefim@chromium.org/291153012/1

6 years, 7 months ago (2014-05-23 22:29:25 UTC) #4

Message was sent while issue was closed.

Change committed as 272730

Expand Messages | Collapse Messages