Update optimize_png_files.sh to work on msysgit bash.

Update optimize_png_files.sh to work on msysgit bash.

This bash is moderately archaic (version 3), and various tools (e.g. tput) are
missing.

This also modifies the ouput of the script so that in verbose mode, as it runs,
each filename is trimmed to fit on one line, including the throbber, then
replaced by the full filename when printing the final file status.  This makes
for a cleaner output spew with long filenames in particular.

BUG=none
TEST=none
R=oshima@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272364

[oshima, 2014-05-22 18:51:43]

https://codereview.chromium.org/291153007/diff/1/tools/resources/optimize-png...
File tools/resources/optimize-png-files.sh (left):

https://codereview.chromium.org/291153007/diff/1/tools/resources/optimize-png...
tools/resources/optimize-png-files.sh:166: info -n "|random"
why removing them?

https://codereview.chromium.org/291153007/diff/1/tools/resources/optimize-png...
File tools/resources/optimize-png-files.sh (right):

https://codereview.chromium.org/291153007/diff/1/tools/resources/optimize-png...
tools/resources/optimize-png-files.sh:330: echo -ne "$file: Unable to reduce
size\n"
info

[Peter Kasting, 2014-05-22 18:57:30]

https://codereview.chromium.org/291153007/diff/1/tools/resources/optimize-png...
File tools/resources/optimize-png-files.sh (left):

https://codereview.chromium.org/291153007/diff/1/tools/resources/optimize-png...
tools/resources/optimize-png-files.sh:166: info -n "|random"
On 2014/05/22 18:51:43, oshima wrote:
> why removing them?

They usually extend the printed text for each filename onto a second line, at
which point you can't easily go back and erase things properly with the final
file status.  In other words, they contribute to the problem of unreadable
console spew when you're working with a lot of files.

Given that we have the throbber anyway, it didn't seem tremendously valuable to
have these.  If they're really important, I could instead reserve sufficient
space for the longest one, and then have each status overwrite the previous one.
 It'd be a bit trickier.

https://codereview.chromium.org/291153007/diff/1/tools/resources/optimize-png...
File tools/resources/optimize-png-files.sh (right):

https://codereview.chromium.org/291153007/diff/1/tools/resources/optimize-png...
tools/resources/optimize-png-files.sh:330: echo -ne "$file: Unable to reduce
size\n"
On 2014/05/22 18:51:43, oshima wrote:
> info

I used echo on purpose, to match the use of echo in the case above where the
filesize has decreased.  We could change both to "info" if you want, but it
seemed reasonable to at least print out per-file results in non-verbose mode.

What do you prefer?

[oshima, 2014-05-22 20:38:04]

https://codereview.chromium.org/291153007/diff/1/tools/resources/optimize-png...
File tools/resources/optimize-png-files.sh (left):

https://codereview.chromium.org/291153007/diff/1/tools/resources/optimize-png...
tools/resources/optimize-png-files.sh:166: info -n "|random"
On 2014/05/22 18:57:31, Peter Kasting wrote:
> On 2014/05/22 18:51:43, oshima wrote:
> > why removing them?
> 
> They usually extend the printed text for each filename onto a second line, at
> which point you can't easily go back and erase things properly with the final
> file status.  In other words, they contribute to the problem of unreadable
> console spew when you're working with a lot of files.
> 
> Given that we have the throbber anyway, it didn't seem tremendously valuable
to
> have these.  If they're really important, I could instead reserve sufficient
> space for the longest one, and then have each status overwrite the previous
one.
>  It'd be a bit trickier.

I added -v for development purpose to see each steps being preformed. I guess
you wanted to
use -v to make sure it processed all files? In that case, how about adding
verbose level and
print all for -v2, but print just filename + result for -v ?

[Peter Kasting, 2014-05-22 22:25:30]

PTAL.  I re-added step display for -v.  Now we reserve sufficient space to
display the longest of the steps, and we display not only the throbber but what
step we're currently on.

So while processing a file, you'll get output like:

foo.png|random../

...where "random" will be the name of the current step, and "/" is the spinning
throbber.

[oshima, 2014-05-22 22:48:00]

ok, lgtm

I'll add verbose level.

[Peter Kasting, 2014-05-22 22:49:51]

On 2014/05/22 22:48:00, oshima wrote:
> I'll add verbose level.

Do you want me to just change both those echos to infos?  I'm not opposed to
doing that if you think that's better.  I'd certainly prefer that to having more
than one verbosity level.

[oshima, 2014-05-22 23:03:39]

On 2014/05/22 22:49:51, Peter Kasting wrote:
> On 2014/05/22 22:48:00, oshima wrote:
> > I'll add verbose level.
> 
> Do you want me to just change both those echos to infos?  I'm not opposed to
> doing that if you think that's better.  I'd certainly prefer that to having
more
> than one verbosity level.

I often (but not always) run this script on all png files before branch cut, and
printing this for all files makes outputs a bit messy.
However, I also understand that this is useful if you just run this for small
set of files.

If you can add verbose level and change echo to info, yes, I prefer that.

[Peter Kasting, 2014-05-22 23:28:35]

Changed echo -> info and did not add any verbosity levels, per IM discussion.

Landing.

[Peter Kasting, 2014-05-22 23:33:05]

Committed patchset #4 manually as r272364 (presubmit successful).