Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 291153005: Consistently say 'own' property (Closed)

Created:
6 years, 7 months ago by rossberg
Modified:
6 years, 7 months ago
Reviewers:
Yang
CC:
v8-dev, Paweł Hajdan Jr., Michael Starzinger
Visibility:
Public.

Description

Consistently say 'own' property R=yangguo@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=21441

Patch Set 1 #

Patch Set 2 : Add new files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+339 lines, -366 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/accessors.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/api.cc View 7 chunks +10 lines, -11 lines 0 comments Download
M src/array.js View 4 chunks +4 lines, -4 lines 0 comments Download
M src/bootstrapper.cc View 16 chunks +22 lines, -22 lines 0 comments Download
M src/contexts.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/factory.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M src/heap-snapshot-generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/i18n.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M src/ic.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/isolate.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M src/json-parser.h View 1 chunk +1 line, -1 line 0 comments Download
M src/json-stringifier.h View 1 chunk +1 line, -1 line 0 comments Download
M src/macros.py View 1 chunk +1 line, -1 line 0 comments Download
M src/messages.js View 1 chunk +1 line, -1 line 0 comments Download
M src/mirror-debugger.js View 2 chunks +4 lines, -4 lines 0 comments Download
M src/objects.h View 12 chunks +21 lines, -21 lines 0 comments Download
M src/objects.cc View 58 chunks +95 lines, -96 lines 0 comments Download
M src/objects-inl.h View 3 chunks +4 lines, -5 lines 0 comments Download
M src/parser.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/promise.js View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/runtime.cc View 47 chunks +82 lines, -84 lines 0 comments Download
M src/scopeinfo.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/scopes.h View 1 chunk +1 line, -1 line 0 comments Download
M src/scopes.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/stub-cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/v8natives.js View 7 chunks +12 lines, -12 lines 0 comments Download
M test/cctest/test-api.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M test/cctest/test-heap.cc View 4 chunks +18 lines, -18 lines 0 comments Download
M test/cctest/test-mark-compact.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D test/mjsunit/runtime-gen/getlocalelementnames.js View 1 chunk +0 lines, -5 lines 0 comments Download
D test/mjsunit/runtime-gen/getlocalpropertynames.js View 1 chunk +0 lines, -6 lines 0 comments Download
A + test/mjsunit/runtime-gen/getownelementnames.js View 1 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/runtime-gen/getownpropertynames.js View 1 1 chunk +1 line, -1 line 0 comments Download
D test/mjsunit/runtime-gen/haslocalproperty.js View 1 chunk +0 lines, -6 lines 0 comments Download
A + test/mjsunit/runtime-gen/hasownproperty.js View 1 1 chunk +1 line, -1 line 0 comments Download
D test/mjsunit/runtime-gen/localkeys.js View 1 chunk +0 lines, -5 lines 0 comments Download
A + test/mjsunit/runtime-gen/ownkeys.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/tools/tickprocessor.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/tools/tickprocessor-test.default View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/tools/tickprocessor-test.ignore-unknown View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/tools/tickprocessor-test.separate-ic View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rossberg
6 years, 7 months ago (2014-05-20 12:09:26 UTC) #1
Yang
LGTM
6 years, 7 months ago (2014-05-20 12:13:54 UTC) #2
rossberg
6 years, 7 months ago (2014-05-22 15:28:52 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r21441 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698