Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 291153002: checklicenses: Recognize licenses from FreeType and Anti-Grain Geometry. (Closed)

Created:
6 years, 7 months ago by Lei Zhang
Modified:
6 years, 7 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Visibility:
Public.

Description

checklicenses: Recognize licenses from FreeType and Anti-Grain Geometry. BUG=177319, 374943 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272927

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M third_party/devscripts/licensecheck.pl View 1 1 chunk +11 lines, -0 lines 0 comments Download
M tools/checklicenses/checklicenses.py View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Lei Zhang
6 years, 7 months ago (2014-05-20 08:19:03 UTC) #1
Paweł Hajdan Jr.
https://codereview.chromium.org/291153002/diff/1/third_party/devscripts/licensecheck.pl File third_party/devscripts/licensecheck.pl (right): https://codereview.chromium.org/291153002/diff/1/third_party/devscripts/licensecheck.pl#newcode636 third_party/devscripts/licensecheck.pl:636: if ($licensetext =~ /Anti-Grain Geometry.*Permission to copy, use, modify, ...
6 years, 7 months ago (2014-05-20 12:41:57 UTC) #2
Lei Zhang
https://codereview.chromium.org/291153002/diff/1/third_party/devscripts/licensecheck.pl File third_party/devscripts/licensecheck.pl (right): https://codereview.chromium.org/291153002/diff/1/third_party/devscripts/licensecheck.pl#newcode636 third_party/devscripts/licensecheck.pl:636: if ($licensetext =~ /Anti-Grain Geometry.*Permission to copy, use, modify, ...
6 years, 7 months ago (2014-05-22 06:57:11 UTC) #3
Paweł Hajdan Jr.
LGTM
6 years, 7 months ago (2014-05-26 13:59:52 UTC) #4
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-05-27 05:40:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/291153002/20001
6 years, 7 months ago (2014-05-27 05:40:50 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-27 05:41:28 UTC) #7
Message was sent while issue was closed.
Change committed as 272927

Powered by Google App Engine
This is Rietveld 408576698