Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3274)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: cc/trees/transform_node.h

Issue 2911463002: Unify the calculation of main thread offset of sticky element (Closed)
Patch Set: Address comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/property_tree_builder.cc ('k') | third_party/WebKit/LayoutTests/compositing/overflow/ancestor-overflow-layer-of-sticky-child-of-compositing-container.html » ('j') | third_party/WebKit/Source/core/paint/PaintLayer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/transform_node.h
diff --git a/cc/trees/transform_node.h b/cc/trees/transform_node.h
index 2abfb1cc00480b7eb14ed6dab868d15a165a4096..7d779fb8e72078a6d6c5b2fad0d39d8567230f9a 100644
--- a/cc/trees/transform_node.h
+++ b/cc/trees/transform_node.h
@@ -55,6 +55,10 @@ struct CC_EXPORT TransformNode {
// transform node. -1 indicates there are no sticky position constraints.
int sticky_position_constraint_id;
+ // This stores the main thread offset applied to the sticky element from main
+ // thread. It's used to calculate the actual sticky position offset from cc.
flackr 2017/06/01 19:01:47 nit: s/actual sticky position offset/additional st
yigu 2017/06/01 19:28:40 Done.
+ gfx::Vector2dF sticky_main_thread_offset;
+
// This is the node with respect to which source_offset is defined. This will
// not be needed once layerization moves to cc, but is needed in order to
// efficiently update the transform tree for changes to position in the layer
« no previous file with comments | « cc/trees/property_tree_builder.cc ('k') | third_party/WebKit/LayoutTests/compositing/overflow/ancestor-overflow-layer-of-sticky-child-of-compositing-container.html » ('j') | third_party/WebKit/Source/core/paint/PaintLayer.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698