Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp

Issue 2911463002: Unify the calculation of main thread offset of sticky element (Closed)
Patch Set: Address comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp b/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
index 2b6992b3c46e81c28b0b71e5389a669e82d4b09a..2930b3fd77a5ec2cfaf8509ea07d73395fd2f695 100644
--- a/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
+++ b/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
@@ -374,8 +374,6 @@ TEST_P(ScrollingCoordinatorTest, fastScrollingForStickyPosition) {
EXPECT_EQ(
IntRect(100, 100, 200, 200),
IntRect(constraint.scroll_container_relative_containing_block_rect));
- EXPECT_EQ(IntPoint(100, 100),
- IntPoint(constraint.parent_relative_sticky_box_offset));
}
{
Element* element = document->getElementById("div-tr");
@@ -451,8 +449,6 @@ TEST_P(ScrollingCoordinatorTest, fastScrollingForStickyPosition) {
EXPECT_EQ(
IntRect(100, 100, 200, 200),
IntRect(constraint.scroll_container_relative_containing_block_rect));
- EXPECT_EQ(IntPoint(0, 10),
- IntPoint(constraint.parent_relative_sticky_box_offset));
}
}

Powered by Google App Engine
This is Rietveld 408576698