third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h - Issue 2911463002: Unify the calculation of main thread offset of sticky element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h

Issue 2911463002: Unify the calculation of main thread offset of sticky element (Closed)

Patch Set: nit Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/trees/property_tree.cc ('K') | « third_party/WebKit/LayoutTests/compositing/overflow/ancestor-overflow-layer-of-sticky-child-of-compositing-container-expected.html ('k') | third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp » ('j') | third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h

index e5a74bee86a38da034dc05cf5d517a90b2e62219..a9c13519cf420c4563f226f3eac8055206676a44 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h

@@ -368,7 +368,7 @@ class CORE_EXPORT CompositedLayerMapping final : public GraphicsLayerClient {

const FloatSize& relative_compositing_bounds_size);

void UpdateScrollingLayerGeometry(const IntRect& local_compositing_bounds);

void UpdateChildClippingMaskLayerGeometry();

- void UpdateStickyConstraints(const ComputedStyle&, const PaintLayer*);

+ void UpdateStickyConstraints(const ComputedStyle&);

void CreatePrimaryGraphicsLayer();

void DestroyGraphicsLayers();