Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Unified Diff: components/password_manager/core/browser/suppressed_https_form_fetcher.h

Issue 2911433003: Refactor SuppressedHTTPSFormsFetcher to use GetLoginsForSameOrganizationName. (Closed)
Patch Set: Comment + rebase. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/suppressed_https_form_fetcher.h
diff --git a/components/password_manager/core/browser/suppressed_https_form_fetcher.h b/components/password_manager/core/browser/suppressed_https_form_fetcher.h
index 26b96392432ee4658dd3522866ab092743228db0..b8123689f408f2729b37ff52ba3bb5a4a832a5d3 100644
--- a/components/password_manager/core/browser/suppressed_https_form_fetcher.h
+++ b/components/password_manager/core/browser/suppressed_https_form_fetcher.h
@@ -12,14 +12,13 @@
#include "base/macros.h"
#include "components/autofill/core/common/password_form.h"
#include "components/password_manager/core/browser/password_store_consumer.h"
-
-class GURL;
+#include "url/gurl.h"
namespace password_manager {
class PasswordManagerClient;
-// Fetches credentials saved for the HTTPS counterpart of the given HTTP origin.
+// Fetches credentials saved for the HTTPS counterpart of the given HTTP realm.
//
// Filling these HTTPS credentials into forms served over HTTP is obviously
// suppressed, the purpose of doing such a query is to collect metrics on how
@@ -36,7 +35,7 @@ class SuppressedHTTPSFormFetcher : public PasswordStoreConsumer {
std::vector<std::unique_ptr<autofill::PasswordForm>> forms) = 0;
};
- SuppressedHTTPSFormFetcher(const GURL& http_origin,
+ SuppressedHTTPSFormFetcher(const std::string& observed_signon_realm,
const PasswordManagerClient* client,
Consumer* consumer);
~SuppressedHTTPSFormFetcher() override;
@@ -54,6 +53,8 @@ class SuppressedHTTPSFormFetcher : public PasswordStoreConsumer {
const PasswordManagerClient* client_;
Consumer* consumer_;
+ const GURL observed_signon_realm_as_url_;
+
DISALLOW_COPY_AND_ASSIGN(SuppressedHTTPSFormFetcher);
};

Powered by Google App Engine
This is Rietveld 408576698