Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: components/password_manager/core/browser/form_fetcher_impl.cc

Issue 2911433003: Refactor SuppressedHTTPSFormsFetcher to use GetLoginsForSameOrganizationName. (Closed)
Patch Set: Comment + rebase. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/password_manager/core/browser/form_fetcher_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/form_fetcher_impl.cc
diff --git a/components/password_manager/core/browser/form_fetcher_impl.cc b/components/password_manager/core/browser/form_fetcher_impl.cc
index e4084a63beebdc836131bccdb97b95c9f37411d3..8b7b55f52f0c5807f1925298dccb62cf476aa79c 100644
--- a/components/password_manager/core/browser/form_fetcher_impl.cc
+++ b/components/password_manager/core/browser/form_fetcher_impl.cc
@@ -141,10 +141,14 @@ void FormFetcherImpl::OnGetPasswordStoreResults(
// If this is a non-secure Web origin (i.e. HTTP), kick off the discovery of
// credentials stored for the secure version of this origin (i.e. HTTPS),
// regardless of whether there are some precisely matching |results|.
+ //
+ // These results are used only for recording metrics at PasswordFormManager
+ // desctruction time, this is why they are requested so late.
if (should_query_suppressed_https_forms_ &&
+ form_digest_.scheme == PasswordForm::SCHEME_HTML &&
form_digest_.origin.SchemeIs(url::kHttpScheme)) {
suppressed_https_form_fetcher_ =
- base::MakeUnique<SuppressedHTTPSFormFetcher>(form_digest_.origin,
+ base::MakeUnique<SuppressedHTTPSFormFetcher>(form_digest_.signon_realm,
client_, this);
}
« no previous file with comments | « no previous file | components/password_manager/core/browser/form_fetcher_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698