third_party/WebKit/LayoutTests/inspector/console/console-context-selector.html - Issue 2911363002: DevTools: Split SoftDropdown out of ConsoleContextSelector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/console/console-context-selector.html

Issue 2911363002: DevTools: Split SoftDropdown out of ConsoleContextSelector (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js ('k') | third_party/WebKit/Source/devtools/BUILD.gn » ('j') | third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/console/console-context-selector.html

diff --git a/third_party/WebKit/LayoutTests/inspector/console/console-context-selector.html b/third_party/WebKit/LayoutTests/inspector/console/console-context-selector.html

index 864a7e4bfa3c5078c8da96e6b995a17399b754ad..145af0a23ea86a341a1a28325d3f16e98ff38c84 100644

--- a/third_party/WebKit/LayoutTests/inspector/console/console-context-selector.html

+++ b/third_party/WebKit/LayoutTests/inspector/console/console-context-selector.html

@@ -98,9 +98,9 @@ async function test()

var consoleView = Console.ConsoleView.instance();

var selector = consoleView._consoleContextSelector;

InspectorTest.addResult('Console context selector:');

- for (var executionContext of selector._list._items) {

+ for (var executionContext of selector._dropdown._list._items) {

var selected = UI.context.flavor(SDK.ExecutionContext) === executionContext;

- var text = '____'.repeat(selector._depthFor(executionContext)) + selector._titleFor(executionContext);

+ var text = '____'.repeat(selector.depthFor(executionContext)) + selector.titleFor(executionContext);

var disabled = !selector.isItemSelectable(executionContext);

InspectorTest.addResult(`${selected ? '*' : ' '} ${text} ${disabled ? '[disabled]' : ''}`);

}