Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2911333002: Allow a function named 'get' to be generic (fixes #29746). (Closed)

Created:
3 years, 6 months ago by regis
Modified:
3 years, 6 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow a function named 'get' to be generic (fixes #29746). Add regression test. Mark status files for failing dartk, dart2js, and analyzer. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/b7ebbf8c7771907eee0acf884da8e9032cd3db68

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -3 lines) Patch
M runtime/vm/parser.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/parser.cc View 3 chunks +18 lines, -3 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language_kernel.status View 1 chunk +1 line, -0 lines 0 comments Download
A tests/language/regress_29349_test.dart View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
regis
3 years, 6 months ago (2017-05-30 21:13:35 UTC) #2
siva
lgtm
3 years, 6 months ago (2017-05-30 22:23:54 UTC) #3
regis
3 years, 6 months ago (2017-05-30 22:31:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b7ebbf8c7771907eee0acf884da8e9032cd3db68.

Powered by Google App Engine
This is Rietveld 408576698