Automatic host installation for IT2Me on Windows.

remoting/webapp/host_install_dialog.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
 /**
@@ skipping 31 matching lines @@
       'chromeremotedesktop.dmg',
   'Linux x86_64' : 'https://dl.google.com/linux/direct/' +
       'chrome-remote-desktop_current_amd64.deb',
   'Linux i386' : 'https://dl.google.com/linux/direct/' +
       'chrome-remote-desktop_current_i386.deb'
 };
 
 /**
  * Starts downloading host components and shows installation prompt.
  *
- * @param {remoting.HostController} hostController Used to install the host on
- *     Windows.
+ * @param {remoting.HostPlugin} hostPlugin Used to install the host on Windows.
  * @param {function(remoting.HostController.AsyncResult):void} onDone Callback
  *     called when user clicks Ok, presumably after installing the host. The
  *     handler must verify that the host has been installed and call tryAgain()
  *     otherwise.
  * @param {function(remoting.Error):void} onError Callback called when user
  *    clicks Cancel button or there is some other unexpected error.
  * @return {void}
  */
 remoting.HostInstallDialog.prototype.show = function(
-    hostController, onDone, onError) {
+    hostPlugin, onDone, onError) {
   // On Windows, host installation is automatic (handled by the NPAPI plugin)
   // and we don't show the dialog. On Mac and Linux, we show the dialog and the
   // user is expected to manually install the host before clicking OK.
   // TODO (weitaosu): Make host installation automatic for IT2Me (like Me2Me) on
   // Windows. Currently hostController is always null for IT2Me.
-  if (navigator.platform == 'Win32' && hostController != null) {
-    hostController.installHost(onDone, onError);
+  if (navigator.platform == 'Win32' && hostPlugin != null) {
+    // Currently we show two dialogs (each with a UAC prompt) when a user
+    // enables the host for the first time, one for installing the host (by the
+    // plugin) and the other for starting the host (by the native messaging
+    // host). We'd like to reduce it to one but don't have a good solution
+    // right now.
+    // We also show the same message on the two dialogs because. We don't want
+    // to confuse the user by saying "Installing Remote Desktop" because in
+    // their mind "Remote Desktop" (the webapp) has already been installed.
+    remoting.showSetupProcessingMessage(/*i18n-content*/'HOST_SETUP_STARTING');
+
+    hostPlugin.installHost(onDone);

[Sergey Ulanov, 2014/05/21 16:07:58]

This just starts installing the host silently. I past we discussed prompting the
user first, at least for It2Me. Is that still the plan?

[weitao, 2014/05/21 18:04:22]

You are right! I had forgot about this after redoing the IT2Me work (last and
this CL) and the two weeks absence. I will fix this.

On 2014/05/21 16:07:58, Sergey Ulanov wrote:

   } else {
     this.continueInstallButton_.addEventListener(
         'click', this.onOkClickedHandler_, false);
     this.cancelInstallButton_.addEventListener(
         'click', this.onCancelClickedHandler_, false);
     remoting.setMode(remoting.AppMode.HOST_INSTALL_PROMPT);
 
     var hostPackageUrl =
         remoting.HostInstallDialog.hostDownloadUrls[navigator.platform];
     if (hostPackageUrl === undefined) {
@@ skipping 52 matching lines @@
 
 remoting.HostInstallDialog.prototype.onRetryClicked_ = function() {
   this.retryInstallButton_.removeEventListener(
       'click', this.onRetryClickedHandler_.bind(this), false);
   this.continueInstallButton_.addEventListener(
       'click', this.onOkClickedHandler_, false);
   this.cancelInstallButton_.addEventListener(
       'click', this.onCancelClickedHandler_, false);
   remoting.setMode(remoting.AppMode.HOST_INSTALL_PROMPT);
 };