Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2911323002: Fix inferInvocation for top level inference. (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix inferInvocation for top level inference. When inferring the type of an invocation for top level inference, if type parameters are not specified, then it is an error. So we should not recurse into subexpressions (even if inferenceNeeded is `true`). This avoids confusion by making it clear to the user that we don't take subexpressions into account when doing top level type inference, even when recovering from type inference errors. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/b89e8cd1a1a0b0e53f49559040b3c82a0fefcf90

Patch Set 1 #

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 6 months ago (2017-05-30 21:10:06 UTC) #2
scheglov
LGTM
3 years, 6 months ago (2017-05-30 21:40:13 UTC) #3
Paul Berry
3 years, 6 months ago (2017-05-30 21:43:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b89e8cd1a1a0b0e53f49559040b3c82a0fefcf90 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698