chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc - Issue 2911293003: Reland: Cache protected password entry and password on focus ping separately.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc

Issue 2911293003: Reland: Cache protected password entry and password on focus ping separately. (Closed)

Patch Set: nit Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/chrome_password_protection_service.cc ('k') | components/content_settings/core/common/content_settings.cc » ('j') | components/safe_browsing/password_protection/password_protection_request.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc

diff --git a/chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc b/chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc

index 348c10c57ec08215e08d782b22efcc44833b8879..72c707a77d4a6b4b4166da4b7a8887553c44591d 100644

--- a/chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc

+++ b/chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc

@@ -75,6 +75,7 @@ class MockChromePasswordProtectionService

}

void CacheVerdict(const GURL& url,

+ LoginReputationClientRequest::TriggerType type,

lpz 2017/06/08 15:18:33 nit: verdict_type or trigger_type?

Jialiu Lin 2017/06/08 20:47:30 Changed to trigger_type.

LoginReputationClientResponse* verdict,

const base::Time& receive_time) override {}