components/safe_browsing/password_protection/password_protection_request.h - Issue 2911293003: Reland: Cache protected password entry and password on focus ping separately.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing/password_protection/password_protection_request.h

Issue 2911293003: Reland: Cache protected password entry and password on focus ping separately. (Closed)

Patch Set: Fix Crashes by Using GetDictionaryWithoutPathExpansion Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/content_settings/core/common/content_settings.cc ('k') | components/safe_browsing/password_protection/password_protection_request.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/safe_browsing/password_protection/password_protection_request.h

diff --git a/components/safe_browsing/password_protection/password_protection_request.h b/components/safe_browsing/password_protection/password_protection_request.h

index 721739b277ec9f29bfed6528591466b0edc95035..756a65d0db0155e2f1226194658fd6aaecc60da8 100644

--- a/components/safe_browsing/password_protection/password_protection_request.h

+++ b/components/safe_browsing/password_protection/password_protection_request.h

@@ -74,8 +74,8 @@ class PasswordProtectionRequest : public base::RefCountedThreadSafe<

content::WebContents* web_contents() const { return web_contents_; }

- LoginReputationClientRequest::TriggerType request_type() const {

- return request_type_;

+ LoginReputationClientRequest::TriggerType trigger_type() const {

+ return trigger_type_;

}

private:

@@ -129,7 +129,7 @@ class PasswordProtectionRequest : public base::RefCountedThreadSafe<

const std::string saved_domain_;

// If this request is for unfamiliar login page or for a password reuse event.

- const LoginReputationClientRequest::TriggerType request_type_;

+ const LoginReputationClientRequest::TriggerType trigger_type_;

// If there is a password field on the page.

const bool password_field_exists_;