Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1319)

Unified Diff: third_party/WebKit/Source/platform/instrumentation/tracing/web_process_memory_dump_test.cc

Issue 2911263003: [memory-infra] Add method to override importance of ownership edges (Closed)
Patch Set: Fixes. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/trace_event/process_memory_dump_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/instrumentation/tracing/web_process_memory_dump_test.cc
diff --git a/third_party/WebKit/Source/platform/instrumentation/tracing/web_process_memory_dump_test.cc b/third_party/WebKit/Source/platform/instrumentation/tracing/web_process_memory_dump_test.cc
index 94dfc59b667e6f6d2d4354266d1fa5cb6bff3844..a3e33532e29f913d8de2248b0fc94804aece5eaa 100644
--- a/third_party/WebKit/Source/platform/instrumentation/tracing/web_process_memory_dump_test.cc
+++ b/third_party/WebKit/Source/platform/instrumentation/tracing/web_process_memory_dump_test.cc
@@ -115,10 +115,12 @@ TEST(WebProcessMemoryDumpTest, IntegrationTest) {
auto wmad4 = wpmd1->CreateMemoryAllocatorDump("1/4");
wpmd1->AddOwnershipEdge(wmad4->Guid(), guid);
auto allocator_dumps_edges =
- wpmd1->process_memory_dump()->allocator_dumps_edges();
+ wpmd1->process_memory_dump()->allocator_dumps_edges_for_testing();
ASSERT_EQ(1u, allocator_dumps_edges.size());
- ASSERT_EQ(wmad4->Guid(), allocator_dumps_edges[0].source.ToUint64());
- ASSERT_EQ(guid, allocator_dumps_edges[0].target.ToUint64());
+ auto it = allocator_dumps_edges.begin();
+ ASSERT_NE(allocator_dumps_edges.end(), it);
+ ASSERT_EQ(wmad4->Guid(), it->first.ToUint64());
+ ASSERT_EQ(guid, it->second.target.ToUint64());
// Check that createDumpAdapterForSkia() works.
auto skia_trace_memory_dump = wpmd1->CreateDumpAdapterForSkia("1/skia");
« no previous file with comments | « base/trace_event/process_memory_dump_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698