Issue 291123002: Ensure that interruptor callback registered through API is called outside of ExecutionAccess lock.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 291123002: Ensure that interruptor callback registered through API is called outside of ExecutionAccess lock. (Closed)

Created:
6 years, 7 months ago by Vyacheslav Egorov (Google)

Modified:
6 years, 7 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Ensure that interruptor callback registered through API is called outside of ExecutionAccess lock. Such a coarse locking can cause a dead-lock when another thread is attempting to clear an interrupt while we are waiting in the interrupt callback. Add test that verifies this API invariant. BUG=chromium:374978 LOG=N R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21376

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+132 lines, -45 lines)			Patch
M	src/execution.cc	View	1 chunk	+34 lines, -27 lines	0 comments	Download
M	src/isolate.cc	View	1 chunk	+10 lines, -4 lines	0 comments	Download
M	test/cctest/test-api.cc	View	10 chunks	+88 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

On 2014/05/20 07:38:25, Vyacheslav Egorov (Google) wrote: > Please take a look. lgtm.

6 years, 7 months ago (2014-05-20 07:41:04 UTC) #2

Vyacheslav Egorov (Google)

6 years, 7 months ago (2014-05-20 08:24:59 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21376 (presubmit successful).

Expand Messages | Collapse Messages