Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: chrome/browser/supervised_user/supervised_user_url_filter.cc

Issue 2911113004: Replace deprecated base::NonThreadSafe in chrome/browser/supervised_user in favor of SequenceChecke… (Closed)
Patch Set: no detach per reviewer request Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/supervised_user/supervised_user_url_filter.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/supervised_user/supervised_user_url_filter.cc
diff --git a/chrome/browser/supervised_user/supervised_user_url_filter.cc b/chrome/browser/supervised_user/supervised_user_url_filter.cc
index 43767fc2a19b4fe478c5d4d96f5fb88710c31a9e..adde909b7cdf8cba76bd3a631677da5cb1324879 100644
--- a/chrome/browser/supervised_user/supervised_user_url_filter.cc
+++ b/chrome/browser/supervised_user/supervised_user_url_filter.cc
@@ -243,12 +243,11 @@ SupervisedUserURLFilter::SupervisedUserURLFilter()
DCHECK(amp_cache_path_regex_.ok());
DCHECK(google_amp_viewer_path_regex_.ok());
DCHECK(google_web_cache_query_regex_.ok());
- // Detach from the current thread so we can be constructed on a different
- // thread than the one where we're used.
- DetachFromThread();
}
-SupervisedUserURLFilter::~SupervisedUserURLFilter() {}
+SupervisedUserURLFilter::~SupervisedUserURLFilter() {
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
+}
// static
SupervisedUserURLFilter::FilteringBehavior
@@ -337,7 +336,7 @@ SupervisedUserURLFilter::GetFilteringBehaviorForURL(
const GURL& url,
bool manual_only,
supervised_user_error_page::FilteringBehaviorReason* reason) const {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
GURL effective_url = GetEmbeddedURL(url);
if (!effective_url.is_valid())
@@ -463,7 +462,7 @@ SupervisedUserURLFilter::GetMatchingWhitelistTitles(const GURL& url) const {
void SupervisedUserURLFilter::SetDefaultFilteringBehavior(
FilteringBehavior behavior) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
default_behavior_ = behavior;
}
@@ -474,7 +473,7 @@ SupervisedUserURLFilter::GetDefaultFilteringBehavior() const {
void SupervisedUserURLFilter::LoadWhitelists(
const std::vector<scoped_refptr<SupervisedUserSiteList>>& site_lists) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
base::PostTaskAndReplyWithResult(
blocking_task_runner_.get(), FROM_HERE,
@@ -494,7 +493,7 @@ bool SupervisedUserURLFilter::HasBlacklist() const {
void SupervisedUserURLFilter::SetFromPatternsForTesting(
const std::vector<std::string>& patterns) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
base::PostTaskAndReplyWithResult(
blocking_task_runner_.get(), FROM_HERE,
@@ -505,7 +504,7 @@ void SupervisedUserURLFilter::SetFromPatternsForTesting(
void SupervisedUserURLFilter::SetFromSiteListsForTesting(
const std::vector<scoped_refptr<SupervisedUserSiteList>>& site_lists) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
base::PostTaskAndReplyWithResult(
blocking_task_runner_.get(), FROM_HERE,
@@ -516,12 +515,12 @@ void SupervisedUserURLFilter::SetFromSiteListsForTesting(
void SupervisedUserURLFilter::SetManualHosts(
std::map<std::string, bool> host_map) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
host_map_ = std::move(host_map);
}
void SupervisedUserURLFilter::SetManualURLs(std::map<GURL, bool> url_map) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
url_map_ = std::move(url_map);
}
@@ -661,7 +660,7 @@ GURL SupervisedUserURLFilter::GetEmbeddedURL(const GURL& url) const {
}
void SupervisedUserURLFilter::SetContents(std::unique_ptr<Contents> contents) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
contents_ = std::move(contents);
for (Observer& observer : observers_)
observer.OnSiteListUpdated();
« no previous file with comments | « chrome/browser/supervised_user/supervised_user_url_filter.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698