Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.http-to-https-redirect-and-register-iframe.html

Issue 2911073002: Upstream service wrkr "HTTP to HTTPS" tests to WPT (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.http-to-https-redirect-and-register-iframe.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/serviceworker/http-to-https-redirect-and-register.html b/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.http-to-https-redirect-and-register-iframe.html
similarity index 79%
rename from third_party/WebKit/LayoutTests/http/tests/serviceworker/http-to-https-redirect-and-register.html
rename to third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.http-to-https-redirect-and-register-iframe.html
index af079056f8624423bc77efa1cd1ac959510e13e6..209c819fa28acf17418af1f219dc32499a681c45 100644
--- a/third_party/WebKit/LayoutTests/http/tests/serviceworker/http-to-https-redirect-and-register.html
+++ b/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.http-to-https-redirect-and-register-iframe.html
@@ -1,4 +1,10 @@
<!DOCTYPE html>
+<!-- This test's file name is prefixed with `chromium.` because while a roughly
+ equivalent version is available in the Web Platform Tests project, the
+ limitations of the WPT infrastructure precludes the use of iframes for this
+ purpose. This version should be maintained only insofar as the functionality
+ under test concerns iframe contexts specifically; otherwise, modifications
+ should be contributed to the shared version. -->
<title>register on a secure page after redirect from an non-secure url</title>
<script src="../resources/testharness.js"></script>
<script src="../resources/testharnessreport.js"></script>
@@ -6,6 +12,7 @@
<script src="resources/test-helpers.js"></script>
<body>
<script>
+'use strict';
// Loads a non-secure url in an iframe, which redirects to |target_url|.
// That page then registers a service worker, and messages back with the result.

Powered by Google App Engine
This is Rietveld 408576698