ui/app_list/search/history_data_store.cc - Issue 2911033002: Remove raw base::DictionaryValue::Set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/app_list/search/history_data_store.cc

Issue 2911033002: Remove raw base::DictionaryValue::Set (Closed)

Patch Set: Proper Windows Fix Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/app_list/search/history_data_store.cc

diff --git a/ui/app_list/search/history_data_store.cc b/ui/app_list/search/history_data_store.cc

index a0e1b29973459d95cf8dde2a892ed74ef9bfd5b4..0f4a315215dcf6707b47ac82b07468ee943a8f9b 100644

--- a/ui/app_list/search/history_data_store.cc

+++ b/ui/app_list/search/history_data_store.cc

@@ -128,7 +128,7 @@ HistoryDataStore::~HistoryDataStore() {

void HistoryDataStore::Init(base::DictionaryValue* cached_dict) {

DCHECK(cached_dict);

cached_dict->SetString(kKeyVersion, kCurrentVersion);

- cached_dict->Set(kKeyAssociations, new base::DictionaryValue);

+ cached_dict->Set(kKeyAssociations, base::MakeUnique<base::DictionaryValue>());

}

void HistoryDataStore::Flush(

« no previous file with comments | « tools/json_schema_compiler/test/objects_unittest.cc ('k') | no next file » | no next file with comments »