tools/json_schema_compiler/test/additional_properties_unittest.cc - Issue 2911033002: Remove raw base::DictionaryValue::Set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/test/additional_properties_unittest.cc

Issue 2911033002: Remove raw base::DictionaryValue::Set (Closed)

Patch Set: Proper Windows Fix Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/json_schema_compiler/test/additional_properties_unittest.cc

diff --git a/tools/json_schema_compiler/test/additional_properties_unittest.cc b/tools/json_schema_compiler/test/additional_properties_unittest.cc

index f62729c46e29a5192dae720a970725fe234db8b8..5bf76dac3f085093e08d2bc4b2c23adbfa0672c7 100644

--- a/tools/json_schema_compiler/test/additional_properties_unittest.cc

+++ b/tools/json_schema_compiler/test/additional_properties_unittest.cc

@@ -21,7 +21,7 @@ TEST(JsonSchemaCompilerAdditionalPropertiesTest,

new base::DictionaryValue());

type_value->SetString("string", "value");

type_value->SetInteger("other", 9);

- type_value->Set("another", list_value.release());

+ type_value->Set("another", std::move(list_value));

std::unique_ptr<AdditionalPropertiesType> type(

new AdditionalPropertiesType());

ASSERT_TRUE(AdditionalPropertiesType::Populate(*type_value, type.get()));