Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: remoting/host/security_key/security_key_extension_session.cc

Issue 2911033002: Remove raw base::DictionaryValue::Set (Closed)
Patch Set: Proper Windows Fix Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/security_key/security_key_extension_session.cc
diff --git a/remoting/host/security_key/security_key_extension_session.cc b/remoting/host/security_key/security_key_extension_session.cc
index 966204dc75a8867ae055a9f6c56f7a04f3d86ab0..bdaa7b8cadb0611396fc1274e1ddeb150212ecfb 100644
--- a/remoting/host/security_key/security_key_extension_session.cc
+++ b/remoting/host/security_key/security_key_extension_session.cc
@@ -4,11 +4,14 @@
#include "remoting/host/security_key/security_key_extension_session.h"
+#include <utility>
+
#include "base/bind.h"
#include "base/json/json_reader.h"
#include "base/json/json_writer.h"
#include "base/logging.h"
#include "base/macros.h"
+#include "base/memory/ptr_util.h"
#include "base/single_thread_task_runner.h"
#include "base/values.h"
#include "remoting/base/logging.h"
@@ -187,11 +190,11 @@ void SecurityKeyExtensionSession::SendMessageToClient(
request.SetString(kMessageType, kDataMessage);
request.SetInteger(kConnectionId, connection_id);
- std::unique_ptr<base::ListValue> bytes(new base::ListValue());
+ auto bytes = base::MakeUnique<base::ListValue>();
for (std::string::const_iterator i = data.begin(); i != data.end(); ++i) {
bytes->AppendInteger(static_cast<unsigned char>(*i));
}
- request.Set(kDataPayload, bytes.release());
+ request.Set(kDataPayload, std::move(bytes));
std::string request_json;
CHECK(base::JSONWriter::Write(request, &request_json));
« no previous file with comments | « remoting/host/it2me/it2me_native_messaging_host.cc ('k') | remoting/host/setup/me2me_native_messaging_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698