Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Unified Diff: remoting/client/plugin/chromoting_instance.cc

Issue 2911033002: Remove raw base::DictionaryValue::Set (Closed)
Patch Set: Proper Windows Fix Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « printing/print_settings_conversion.cc ('k') | remoting/host/it2me/it2me_native_messaging_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/client/plugin/chromoting_instance.cc
diff --git a/remoting/client/plugin/chromoting_instance.cc b/remoting/client/plugin/chromoting_instance.cc
index ecaa19a3fa7986b10ad422eaa09b92fde9800e11..95c0fe4ca2c37f892a1363529a01344f06a779bf 100644
--- a/remoting/client/plugin/chromoting_instance.cc
+++ b/remoting/client/plugin/chromoting_instance.cc
@@ -360,7 +360,7 @@ void ChromotingInstance::OnVideoFrameDirtyRegion(
}
std::unique_ptr<base::DictionaryValue> data(new base::DictionaryValue());
- data->Set("rects", rects_value.release());
+ data->Set("rects", std::move(rects_value));
PostLegacyJsonMessage("onDebugRegion", std::move(data));
}
@@ -1002,7 +1002,7 @@ void ChromotingInstance::PostLegacyJsonMessage(
std::unique_ptr<base::DictionaryValue> data) {
base::DictionaryValue message;
message.SetString("method", method);
- message.Set("data", data.release());
+ message.Set("data", std::move(data));
std::string message_json;
base::JSONWriter::Write(message, &message_json);
« no previous file with comments | « printing/print_settings_conversion.cc ('k') | remoting/host/it2me/it2me_native_messaging_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698