Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Unified Diff: net/test/spawned_test_server/base_test_server.cc

Issue 2911033002: Remove raw base::DictionaryValue::Set (Closed)
Patch Set: Proper Windows Fix Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/reporting/reporting_delivery_agent.cc ('k') | printing/print_settings_conversion.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/test/spawned_test_server/base_test_server.cc
diff --git a/net/test/spawned_test_server/base_test_server.cc b/net/test/spawned_test_server/base_test_server.cc
index ab46afb3c0c247bdad5f7651eb0ddd3a915f3535..5ad64cd02d1692facef044aae8d69449f93a673c 100644
--- a/net/test/spawned_test_server/base_test_server.cc
+++ b/net/test/spawned_test_server/base_test_server.cc
@@ -85,18 +85,18 @@ void GetCiphersList(int cipher, base::ListValue* values) {
values->AppendString("aes128gcm");
}
-base::Value* GetTLSIntoleranceType(
+std::unique_ptr<base::Value> GetTLSIntoleranceType(
BaseTestServer::SSLOptions::TLSIntoleranceType type) {
switch (type) {
case BaseTestServer::SSLOptions::TLS_INTOLERANCE_ALERT:
- return new base::Value("alert");
+ return base::MakeUnique<base::Value>("alert");
case BaseTestServer::SSLOptions::TLS_INTOLERANCE_CLOSE:
- return new base::Value("close");
+ return base::MakeUnique<base::Value>("close");
case BaseTestServer::SSLOptions::TLS_INTOLERANCE_RESET:
- return new base::Value("reset");
+ return base::MakeUnique<base::Value>("reset");
default:
NOTREACHED();
- return new base::Value("");
+ return base::MakeUnique<base::Value>("");
}
}
« no previous file with comments | « net/reporting/reporting_delivery_agent.cc ('k') | printing/print_settings_conversion.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698