Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Unified Diff: ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc

Issue 2911033002: Remove raw base::DictionaryValue::Set (Closed)
Patch Set: Proper Windows Fix Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ui/webui/flags_ui.cc ('k') | ipc/ipc_message_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc
diff --git a/ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc b/ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc
index 164e4c116ea8eb63da1547b623ba7d40ced48968..b4d52145fed2c9fb47140d8c2a8cff71c80693bd 100644
--- a/ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc
+++ b/ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc
@@ -4,6 +4,7 @@
#include "ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.h"
+#include <utility>
#include <vector>
#include "base/logging.h"
@@ -125,7 +126,7 @@ void SyncInternalsMessageHandler::HandleRequestListOfTypes(
it.Inc()) {
type_list->AppendString(ModelTypeToString(it.Get()));
}
- event_details.Set(syncer::sync_ui_util::kTypes, type_list.release());
+ event_details.Set(syncer::sync_ui_util::kTypes, std::move(type_list));
web_ui()->CallJavascriptFunction(
syncer::sync_ui_util::kDispatchEvent,
base::Value(syncer::sync_ui_util::kOnReceivedListOfTypes), event_details);
@@ -192,7 +193,7 @@ void SyncInternalsMessageHandler::EmitCounterUpdate(
std::unique_ptr<base::DictionaryValue> details(new base::DictionaryValue());
details->SetString(syncer::sync_ui_util::kModelType, ModelTypeToString(type));
details->SetString(syncer::sync_ui_util::kCounterType, counter_type);
- details->Set(syncer::sync_ui_util::kCounters, value.release());
+ details->Set(syncer::sync_ui_util::kCounters, std::move(value));
web_ui()->CallJavascriptFunction(
syncer::sync_ui_util::kDispatchEvent,
base::Value(syncer::sync_ui_util::kOnCountersUpdated), *details);
« no previous file with comments | « ios/chrome/browser/ui/webui/flags_ui.cc ('k') | ipc/ipc_message_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698