Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: chrome/test/chromedriver/server/http_handler.cc

Issue 2911033002: Remove raw base::DictionaryValue::Set (Closed)
Patch Set: Proper Windows Fix Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/performance_logger.cc ('k') | chromecast/browser/cast_net_log.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/server/http_handler.cc
diff --git a/chrome/test/chromedriver/server/http_handler.cc b/chrome/test/chromedriver/server/http_handler.cc
index 6555063be2683b3e6d4ba03c2ba2b2d5723620a1..a4d9d5b2fc08b044e2ba17c5181301655b4b82b3 100644
--- a/chrome/test/chromedriver/server/http_handler.cc
+++ b/chrome/test/chromedriver/server/http_handler.cc
@@ -771,7 +771,7 @@ std::unique_ptr<net::HttpServerResponseInfo> HttpHandler::PrepareLegacyResponse(
base::DictionaryValue body_params;
body_params.SetInteger("status", status.code());
- body_params.Set("value", value.release());
+ body_params.Set("value", std::move(value));
body_params.SetString("sessionId", session_id);
std::string body;
base::JSONWriter::WriteWithOptions(
@@ -848,7 +848,7 @@ HttpHandler::PrepareStandardResponse(
} else {
body_params.SetString("sessionId", session_id);
body_params.SetString("status", status.message());
- body_params.Set("value", value.release());
+ body_params.Set("value", std::move(value));
}
std::string body;
« no previous file with comments | « chrome/test/chromedriver/performance_logger.cc ('k') | chromecast/browser/cast_net_log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698