Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: third_party/dom_distiller_js/test_sample_json_converter.h.golden

Issue 2911033002: Remove raw base::DictionaryValue::Set (Closed)
Patch Set: Proper Windows Fix Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // GENERATED FILE 1 // GENERATED FILE
2 // This file generated by DomDistillerJs protoc plugin. 2 // This file generated by DomDistillerJs protoc plugin.
3 #include "test_sample.pb.h" 3 #include "test_sample.pb.h"
4 4
5 // base dependencies 5 // base dependencies
6 #include "base/memory/ptr_util.h"
6 #include "base/values.h" 7 #include "base/values.h"
7 8
8 #include <memory> 9 #include <memory>
9 #include <string> 10 #include <string>
10 #include <utility> 11 #include <utility>
11 12
12 namespace dom_distiller { 13 namespace dom_distiller {
13 namespace test_sample { 14 namespace test_sample {
14 namespace proto { 15 namespace proto {
15 namespace json { 16 namespace json {
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 } 144 }
144 return true; 145 return true;
145 146
146 error: 147 error:
147 return false; 148 return false;
148 } 149 }
149 150
150 static std::unique_ptr<base::DictionaryValue> WriteToValue(const dom _distiller::test_sample::proto::Repeated::Message& message) { 151 static std::unique_ptr<base::DictionaryValue> WriteToValue(const dom _distiller::test_sample::proto::Repeated::Message& message) {
151 std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryVa lue()); 152 std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryVa lue());
152 { 153 {
153 base::ListValue* field_list = new base::ListValue(); 154 auto field_list = base::MakeUnique<base::ListValue>();
154 dict->Set("1", field_list);
155 for (int i = 0; i < message.dummy_size(); ++i) { 155 for (int i = 0; i < message.dummy_size(); ++i) {
156 field_list->AppendBoolean(message.dummy(i)); 156 field_list->AppendBoolean(message.dummy(i));
157 } 157 }
158 dict->Set("1", std::move(field_list));
158 } 159 }
159 return dict; 160 return dict;
160 } 161 }
161 }; 162 };
162 163
163 static bool ReadFromValue(const base::Value* json, dom_distiller::test _sample::proto::Repeated* message) { 164 static bool ReadFromValue(const base::Value* json, dom_distiller::test _sample::proto::Repeated* message) {
164 const base::DictionaryValue* dict; 165 const base::DictionaryValue* dict;
165 if (!json->GetAsDictionary(&dict)) goto error; 166 if (!json->GetAsDictionary(&dict)) goto error;
166 if (dict->HasKey("1")) { 167 if (dict->HasKey("1")) {
167 const base::ListValue* field_list; 168 const base::ListValue* field_list;
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
245 } 246 }
246 return true; 247 return true;
247 248
248 error: 249 error:
249 return false; 250 return false;
250 } 251 }
251 252
252 static std::unique_ptr<base::DictionaryValue> WriteToValue(const dom_d istiller::test_sample::proto::Repeated& message) { 253 static std::unique_ptr<base::DictionaryValue> WriteToValue(const dom_d istiller::test_sample::proto::Repeated& message) {
253 std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValu e()); 254 std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValu e());
254 { 255 {
255 base::ListValue* field_list = new base::ListValue(); 256 auto field_list = base::MakeUnique<base::ListValue>();
256 dict->Set("1", field_list);
257 for (int i = 0; i < message.float_value_size(); ++i) { 257 for (int i = 0; i < message.float_value_size(); ++i) {
258 field_list->AppendDouble(message.float_value(i)); 258 field_list->AppendDouble(message.float_value(i));
259 } 259 }
260 dict->Set("1", std::move(field_list));
260 } 261 }
261 { 262 {
262 base::ListValue* field_list = new base::ListValue(); 263 auto field_list = base::MakeUnique<base::ListValue>();
263 dict->Set("2", field_list);
264 for (int i = 0; i < message.double_value_size(); ++i) { 264 for (int i = 0; i < message.double_value_size(); ++i) {
265 field_list->AppendDouble(message.double_value(i)); 265 field_list->AppendDouble(message.double_value(i));
266 } 266 }
267 dict->Set("2", std::move(field_list));
267 } 268 }
268 { 269 {
269 base::ListValue* field_list = new base::ListValue(); 270 auto field_list = base::MakeUnique<base::ListValue>();
270 dict->Set("3", field_list);
271 for (int i = 0; i < message.int32_value_size(); ++i) { 271 for (int i = 0; i < message.int32_value_size(); ++i) {
272 field_list->AppendInteger(message.int32_value(i)); 272 field_list->AppendInteger(message.int32_value(i));
273 } 273 }
274 dict->Set("3", std::move(field_list));
274 } 275 }
275 { 276 {
276 base::ListValue* field_list = new base::ListValue(); 277 auto field_list = base::MakeUnique<base::ListValue>();
277 dict->Set("4", field_list);
278 for (int i = 0; i < message.bool_value_size(); ++i) { 278 for (int i = 0; i < message.bool_value_size(); ++i) {
279 field_list->AppendBoolean(message.bool_value(i)); 279 field_list->AppendBoolean(message.bool_value(i));
280 } 280 }
281 dict->Set("4", std::move(field_list));
281 } 282 }
282 { 283 {
283 base::ListValue* field_list = new base::ListValue(); 284 auto field_list = base::MakeUnique<base::ListValue>();
284 dict->Set("5", field_list);
285 for (int i = 0; i < message.string_value_size(); ++i) { 285 for (int i = 0; i < message.string_value_size(); ++i) {
286 field_list->AppendString(message.string_value(i)); 286 field_list->AppendString(message.string_value(i));
287 } 287 }
288 dict->Set("5", std::move(field_list));
288 } 289 }
289 { 290 {
290 base::ListValue* field_list = new base::ListValue(); 291 auto field_list = base::MakeUnique<base::ListValue>();
291 dict->Set("6", field_list);
292 for (int i = 0; i < message.message_value_size(); ++i) { 292 for (int i = 0; i < message.message_value_size(); ++i) {
293 std::unique_ptr<base::Value> inner_message_value = 293 std::unique_ptr<base::Value> inner_message_value =
294 dom_distiller::test_sample::proto::json::Repeated::Message:: WriteToValue(message.message_value(i)); 294 dom_distiller::test_sample::proto::json::Repeated::Message:: WriteToValue(message.message_value(i));
295 field_list->Append(std::move(inner_message_value)); 295 field_list->Append(std::move(inner_message_value));
296 } 296 }
297 dict->Set("6", std::move(field_list));
297 } 298 }
298 return dict; 299 return dict;
299 } 300 }
300 }; 301 };
301 302
302 } 303 }
303 } 304 }
304 } 305 }
305 } 306 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698