Remove raw base::DictionaryValue::Set

ios/chrome/browser/notification_promo_unittest.cc

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include <memory>
+#include <utility>
 #include <vector>
 
 #include "base/json/json_reader.h"
 #include "base/memory/ptr_util.h"
 #include "base/metrics/field_trial.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/mock_entropy_provider.h"
 #include "base/time/time.h"
@@ skipping 278 matching lines @@
     int views = max_views_ + 1;
     bool closed = true;
 
     // Save data into old prefs structure.
     auto ntp_promo = base::MakeUnique<base::DictionaryValue>();
     ntp_promo->SetInteger("id", promo.promo_id_);
     ntp_promo->SetDouble("first_view_time", first_view_time);
     ntp_promo->SetInteger("views", views);
     ntp_promo->SetBoolean("closed", true);
 
-    base::ListValue* promo_list = new base::ListValue;
+    auto promo_list = base::MakeUnique<base::ListValue>();
     promo_list->Append(std::move(ntp_promo));
 
     std::string promo_list_key = "mobile_ntp_whats_new_promo";
     std::string promo_dict_key = "ios.ntppromo";
 
     base::DictionaryValue promo_dict;
-    promo_dict.Set(promo_list_key, promo_list);
+    promo_dict.Set(promo_list_key, std::move(promo_list));
     local_state_.Set(promo_dict_key, promo_dict);
 
     // Initialize promo and verify that its instance variables match the data
     // saved in the old structure.
     promo.InitFromPrefs();
     EXPECT_DOUBLE_EQ(first_view_time, promo.first_view_time_);
     EXPECT_EQ(views, promo.views_);
     EXPECT_EQ(closed, promo.closed_);
     EXPECT_FALSE(promo.CanShow());
 
@@ skipping 111 matching lines @@
       "  \"promo_id\":0"
       "}",
       "What do you think of Chrome?",
       933672366,  // unix epoch for 3 Aug 1999 9:26:06 GMT.
       0, 30, 30);
   InitPromoFromVariations();
   TestMigrationOfOldPrefs();
 }
 
 }  // namespace ios