Remove raw base::DictionaryValue::Set

extensions/browser/api/storage/settings_test_util.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/storage/settings_test_util.h"
 
+#include <utility>
+
 #include "base/files/file_path.h"
+#include "base/memory/ptr_util.h"
 #include "base/run_loop.h"
+#include "base/values.h"
 #include "extensions/browser/api/storage/storage_frontend.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extension_system_provider.h"
 #include "extensions/browser/extensions_browser_client.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/permissions/permissions_data.h"
 
 namespace extensions {
 
 namespace settings_test_util {
@@ skipping 51 matching lines @@
     const std::set<std::string>& permissions_set) {
   base::DictionaryValue manifest;
   manifest.SetString("name", std::string("Test extension ") + id);
   manifest.SetString("version", "1.0");
 
   std::unique_ptr<base::ListValue> permissions(new base::ListValue());
   for (std::set<std::string>::const_iterator it = permissions_set.begin();
       it != permissions_set.end(); ++it) {
     permissions->AppendString(*it);
   }
-  manifest.Set("permissions", permissions.release());
+  manifest.Set("permissions", std::move(permissions));
 
   switch (type) {
     case Manifest::TYPE_EXTENSION:
       break;
 
     case Manifest::TYPE_LEGACY_PACKAGED_APP: {
-      base::DictionaryValue* app = new base::DictionaryValue();
-      base::DictionaryValue* app_launch = new base::DictionaryValue();
+      auto app = base::MakeUnique<base::DictionaryValue>();
+      auto app_launch = base::MakeUnique<base::DictionaryValue>();
       app_launch->SetString("local_path", "fake.html");
-      app->Set("launch", app_launch);
-      manifest.Set("app", app);
+      app->Set("launch", std::move(app_launch));
+      manifest.Set("app", std::move(app));
       break;
     }
 
     default:
       NOTREACHED();
   }
 
   std::string error;
   scoped_refptr<const Extension> extension(
       Extension::Create(base::FilePath(),
@@ skipping 13 matching lines @@
       it != permissions_set.end(); ++it) {
     DCHECK(extension->permissions_data()->HasAPIPermission(*it));
   }
 
   return extension;
 }
 
 }  // namespace settings_test_util
 
 }  // namespace extensions