Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Side by Side Diff: components/policy/core/common/policy_loader_win_unittest.cc

Issue 2911033002: Remove raw base::DictionaryValue::Set (Closed)
Patch Set: Proper Windows Fix Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/policy/core/common/policy_loader_win.h" 5 #include "components/policy/core/common/policy_loader_win.h"
6 6
7 #include <windows.h> 7 #include <windows.h>
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 #include <userenv.h> 10 #include <userenv.h>
(...skipping 791 matching lines...) Expand 10 before | Expand all | Expand 10 after
802 .LoadFrom(&expected_policy, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, 802 .LoadFrom(&expected_policy, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
803 POLICY_SOURCE_PLATFORM); 803 POLICY_SOURCE_PLATFORM);
804 return Matches(expected); 804 return Matches(expected);
805 } 805 }
806 806
807 bool MatchesTestBundle() { 807 bool MatchesTestBundle() {
808 base::DictionaryValue expected_policy; 808 base::DictionaryValue expected_policy;
809 expected_policy.SetBoolean(test_keys::kKeyBoolean, true); 809 expected_policy.SetBoolean(test_keys::kKeyBoolean, true);
810 expected_policy.SetString(test_keys::kKeyString, "GPO"); 810 expected_policy.SetString(test_keys::kKeyString, "GPO");
811 expected_policy.SetInteger(test_keys::kKeyInteger, 42); 811 expected_policy.SetInteger(test_keys::kKeyInteger, 42);
812 std::unique_ptr<base::ListValue> list(new base::ListValue()); 812 auto list = base::MakeUnique<base::ListValue>();
813 list->AppendString("GPO 1"); 813 list->AppendString("GPO 1");
814 list->AppendString("GPO 2"); 814 list->AppendString("GPO 2");
815 expected_policy.Set(test_keys::kKeyStringList, list.release()); 815 expected_policy.Set(test_keys::kKeyStringList, std::move(list));
816 PolicyBundle expected; 816 PolicyBundle expected;
817 expected.Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string())) 817 expected.Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()))
818 .LoadFrom(&expected_policy, POLICY_LEVEL_MANDATORY, 818 .LoadFrom(&expected_policy, POLICY_LEVEL_MANDATORY,
819 POLICY_SCOPE_MACHINE, POLICY_SOURCE_PLATFORM); 819 POLICY_SCOPE_MACHINE, POLICY_SOURCE_PLATFORM);
820 return Matches(expected); 820 return Matches(expected);
821 } 821 }
822 822
823 ScopedGroupPolicyRegistrySandbox registry_sandbox_; 823 ScopedGroupPolicyRegistrySandbox registry_sandbox_;
824 PGROUP_POLICY_OBJECT gpo_list_; 824 PGROUP_POLICY_OBJECT gpo_list_;
825 DWORD gpo_list_status_; 825 DWORD gpo_list_status_;
(...skipping 391 matching lines...) Expand 10 before | Expand all | Expand 10 after
1217 expected.Get(ns_a).LoadFrom(&expected_a, POLICY_LEVEL_MANDATORY, 1217 expected.Get(ns_a).LoadFrom(&expected_a, POLICY_LEVEL_MANDATORY,
1218 POLICY_SCOPE_MACHINE, POLICY_SOURCE_PLATFORM); 1218 POLICY_SCOPE_MACHINE, POLICY_SOURCE_PLATFORM);
1219 base::DictionaryValue expected_b; 1219 base::DictionaryValue expected_b;
1220 expected_b.SetInteger("policy 1", 2); 1220 expected_b.SetInteger("policy 1", 2);
1221 expected.Get(ns_b).LoadFrom(&expected_b, POLICY_LEVEL_MANDATORY, 1221 expected.Get(ns_b).LoadFrom(&expected_b, POLICY_LEVEL_MANDATORY,
1222 POLICY_SCOPE_MACHINE, POLICY_SOURCE_PLATFORM); 1222 POLICY_SCOPE_MACHINE, POLICY_SOURCE_PLATFORM);
1223 EXPECT_TRUE(Matches(expected)); 1223 EXPECT_TRUE(Matches(expected));
1224 } 1224 }
1225 1225
1226 } // namespace policy 1226 } // namespace policy
OLDNEW
« no previous file with comments | « components/policy/core/common/mac_util.cc ('k') | components/policy/core/common/registry_dict_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698