Various checks for constant expressions.

Various checks for constant expressions.

Fixes https://github.com/dart-lang/sdk/issues/29379

R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/c0bf4eddbe0d6bd3fad3f400db5633b557b8deb0

[ahe, 2017-05-29 16:11:26]

Patchset #1 (id:1) has been deleted

[ahe, 2017-05-29 16:12:41]

ahe@google.com changed reviewers:
+ johnniwinther@google.com, paulberry@google.com

[ahe, 2017-05-30 09:56:29]

New patch set uploaded.

https://codereview.chromium.org/2911023002/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart (right):

https://codereview.chromium.org/2911023002/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart:306: // TODO(ahe):
Remove this?
I've invested the 50-60 minutes it took to answer this question, and I can
remove it :-)

[Johnni Winther, 2017-05-30 10:55:05]

lgtm

[ahe, 2017-05-31 13:57:08]

Description was changed from

==========
Various checks for constant expressions.

Fixes https://github.com/dart-lang/sdk/issues/29379
==========

to

==========
Various checks for constant expressions.

Fixes https://github.com/dart-lang/sdk/issues/29379

R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c0bf4eddbe0d6bd3fad3f400db5633b557b8deb0
==========

[ahe, 2017-05-31 13:57:10]

Committed patchset #2 (id:40001) manually as
c0bf4eddbe0d6bd3fad3f400db5633b557b8deb0 (presubmit successful).