Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Side by Side Diff: components/browsing_data/core/browsing_data_utils.h

Issue 2910983002: Improve and fix counter texts (Closed)
Patch Set: fix ios failures, add random change to browsing_data_utils.h to trigger all tests Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_BROWSING_DATA_CORE_BROWSING_DATA_UTILS_H_ 5 #ifndef COMPONENTS_BROWSING_DATA_CORE_BROWSING_DATA_UTILS_H_
6 #define COMPONENTS_BROWSING_DATA_CORE_BROWSING_DATA_UTILS_H_ 6 #define COMPONENTS_BROWSING_DATA_CORE_BROWSING_DATA_UTILS_H_
7 7
8 #include "base/strings/string16.h" 8 #include "base/strings/string16.h"
9 #include "base/time/time.h" 9 #include "base/time/time.h"
10 #include "components/browsing_data/core/clear_browsing_data_tab.h" 10 #include "components/browsing_data/core/clear_browsing_data_tab.h"
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 // Calculate the begin time for the deletion range specified by |time_period|. 45 // Calculate the begin time for the deletion range specified by |time_period|.
46 base::Time CalculateBeginDeleteTime(TimePeriod time_period); 46 base::Time CalculateBeginDeleteTime(TimePeriod time_period);
47 47
48 // Calculate the end time for the deletion range specified by |time_period|. 48 // Calculate the end time for the deletion range specified by |time_period|.
49 base::Time CalculateEndDeleteTime(TimePeriod time_period); 49 base::Time CalculateEndDeleteTime(TimePeriod time_period);
50 50
51 // Records the UMA action of UI-triggered data deletion for |time_period|. 51 // Records the UMA action of UI-triggered data deletion for |time_period|.
52 void RecordDeletionForPeriod(TimePeriod time_period); 52 void RecordDeletionForPeriod(TimePeriod time_period);
53 53
54 // Constructs the text to be displayed by a counter from the given |result|. 54 // Constructs the text to be displayed by a counter from the given |result|.
55 // Currently this can only be used for counters for which the Result is defined 55 // Currently this can only be used for counters for which the Result is
56 // in components/browsing_data/core/counters. 56 // defined in components/browsing_data/core/counters.
57 base::string16 GetCounterTextFromResult( 57 base::string16 GetCounterTextFromResult(
58 const BrowsingDataCounter::Result* result); 58 const BrowsingDataCounter::Result* result);
59 59
60 // Returns the preference that stores the time period. 60 // Returns the preference that stores the time period.
61 const char* GetTimePeriodPreferenceName( 61 const char* GetTimePeriodPreferenceName(
62 ClearBrowsingDataTab clear_browsing_data_tab); 62 ClearBrowsingDataTab clear_browsing_data_tab);
63 63
64 // Copies the name of the deletion preference corresponding to the given 64 // Copies the name of the deletion preference corresponding to the given
65 // |data_type| to |out_pref|. Returns false if no such preference exists. 65 // |data_type| to |out_pref|. Returns false if no such preference exists.
66 bool GetDeletionPreferenceFromDataType( 66 bool GetDeletionPreferenceFromDataType(
67 BrowsingDataType data_type, 67 BrowsingDataType data_type,
68 ClearBrowsingDataTab clear_browsing_data_tab, 68 ClearBrowsingDataTab clear_browsing_data_tab,
69 std::string* out_pref); 69 std::string* out_pref);
70 70
71 // Copies the deletion preferences for timeperiod, cache, history and cookies 71 // Copies the deletion preferences for timeperiod, cache, history and cookies
72 // to a separate preferences that are used to on the basic CBD tab. 72 // to a separate preferences that are used to on the basic CBD tab.
73 // This only happens the first time this method is called. 73 // This only happens the first time this method is called.
74 void MigratePreferencesToBasic(PrefService* prefs); 74 void MigratePreferencesToBasic(PrefService* prefs);
75 75
76 } // namespace browsing_data 76 } // namespace browsing_data
77 77
78 #endif // COMPONENTS_BROWSING_DATA_CORE_BROWSING_DATA_UTILS_H_ 78 #endif // COMPONENTS_BROWSING_DATA_CORE_BROWSING_DATA_UTILS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698