Worklet: Enqueue tasks into outsideSetting's event loop

third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/workers/MainThreadWorkletGlobalScope.h"
 
 #include "bindings/core/v8/ScriptSourceCode.h"
 #include "bindings/core/v8/WorkerOrWorkletScriptController.h"
 #include "core/dom/Document.h"
 #include "core/dom/Modulator.h"
@@ skipping 34 matching lines @@
   Deprecation::CountDeprecation(GetFrame(), feature);
 }
 
 WorkerThread* MainThreadWorkletGlobalScope::GetThread() const {
   NOTREACHED();
   return nullptr;
 }
 
 // Implementation of the first half of the "fetch and invoke a worklet script"
 // algorithm:
 // https://drafts.css-houdini.org/worklets/#fetch-and-invoke-a-worklet-script

[falken, 2017/05/30 01:33:23]

Not sure if this documentation is better on the impl or interface. I like the
link to the spec since it's clear where the "Step" comments below are from.
Maybe it makes sense to put it on both? Although from the caller's point of
view, this function does the entire "fetch and invoke a worklet script"
algorithm so maybe the interface comment doesn't need to mention "first half" as
that's an impl detail.

[nhiroki, 2017/05/30 02:14:23]

Yeah, it makes sense. Added a comment on the header.
Good point. I didn't add "first half" part to the header comment.

 void MainThreadWorkletGlobalScope::FetchAndInvokeScript(
     const KURL& module_url_record,
     WebURLRequest::FetchCredentialsMode credentials_mode,
+    ParentFrameTaskRunners* task_runners,
     WorkletPendingTasks* pending_tasks) {
   DCHECK(IsMainThread());
   // Step 1: "Let insideSettings be the workletGlobalScope's associated
   // environment settings object."
   // Step 2: "Let script by the result of fetch a worklet script given
   // moduleURLRecord, moduleResponsesMap, credentialOptions, outsideSettings,
   // and insideSettings when it asynchronously completes."
   String nonce = "";
   ParserDisposition parser_state = kNotParserInserted;
   Modulator* modulator = Modulator::From(ScriptController()->GetScriptState());
   ModuleScriptFetchRequest module_request(module_url_record, nonce,
                                           parser_state, credentials_mode);
 
   // Step 3 to 5 are implemented in
   // WorkletModuleTreeClient::NotifyModuleTreeLoadFinished.
   WorkletModuleTreeClient* client =
-      new WorkletModuleTreeClient(modulator, pending_tasks);
+      new WorkletModuleTreeClient(modulator, task_runners, pending_tasks);
   modulator->FetchTree(module_request, client);
 }
 
 // TODO(nhiroki): Add tests for termination.
 void MainThreadWorkletGlobalScope::Terminate() {
   Dispose();
 }
 
 void MainThreadWorkletGlobalScope::AddConsoleMessage(
     ConsoleMessage* console_message) {
   GetFrame()->Console().AddMessage(console_message);
 }
 
 void MainThreadWorkletGlobalScope::ExceptionThrown(ErrorEvent* event) {
   MainThreadDebugger::Instance()->ExceptionThrown(this, event);
 }
 
 CoreProbeSink* MainThreadWorkletGlobalScope::GetProbeSink() {
   return probe::ToCoreProbeSink(GetFrame());
 }
 
 DEFINE_TRACE(MainThreadWorkletGlobalScope) {
   WorkletGlobalScope::Trace(visitor);
   ContextClient::Trace(visitor);
 }
 
 }  // namespace blink